Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop free scrolling on app hide #901

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Stop free scrolling on app hide #901

merged 6 commits into from
Sep 15, 2023

Commits on Sep 15, 2023

  1. Stop free scrolling on app hide 

    b/290655439
b/290846002

Change-Id: I11dc576104b4cac75537ed95392a6f175d4dc4b3
    @andrewsavage1
    andrewsavage1 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2965215 View commit details
    Browse the repository at this point in the history

  2. Remove pure virtual class definition from sources 

    Causes a gn check error due to scroll engine depending on lifecycle observer.

b/290846002
    @andrewsavage1
    andrewsavage1 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2802dfd View commit details
    Browse the repository at this point in the history

  3. Clean up scroll engine in destructor 

    b/290846002
    @andrewsavage1
    andrewsavage1 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6905db8 View commit details
    Browse the repository at this point in the history

  4. Clean up scroll engine observer before creation 

    b/290846002
    @andrewsavage1
    andrewsavage1 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5efadb2 View commit details
    Browse the repository at this point in the history

  5. Have scroll use pointer capture for targets 

    b/290846002
    @andrewsavage1
    andrewsavage1 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2849a74 View commit details
    Browse the repository at this point in the history

  6. Use previous_html_element_weak_ for pointer out events

    @andrewsavage1
    andrewsavage1 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    b3635ba View commit details
    Browse the repository at this point in the history