Fix 30 tests from PlayerComponentsTests testcase in player_filter_tests. #585
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
b/218420648 Change-Id: Iccf6bc3843fa12796a2a54ec8b16e49da35f7bd9
| @@ -382,8 +382,7 @@ class PlayerComponentsTest | |||
| // working. | |||
| void RenderAndProcessPendingJobs() { | |||
| // Call GetCurrentDecodeTarget() periodically for decode to texture mode. | |||
There was a problem hiding this comment.
This comment can be removed or changed since it's not longer limited to just decode to texture mode
There was a problem hiding this comment.
Fixed in commit 6162a2b
There was a problem hiding this comment.
Nit: The commit message of the 2nd commit is the same as the first. The commit message should convey the contents on the commit. In this case it could be e.g. "Fix outdated comment"
There was a problem hiding this comment.
Re-running Android jobs, it looks like a few failed earlier: https://github.com/youtube/cobalt/actions/runs/5243606979/jobs/9468961078
|
I'm running this change on internal tests |
b/218420648 Change-Id: Iccf6bc3843fa12796a2a54ec8b16e49da35f7bd9
|
Tests appear to be passing, and android and raspi seem flaky. I think it's ok to merge, but we should keep an eye on it. |
… in player_filter_tests. (#675) * Fix 30 tests from PlayerComponentsTests testcase in player_filter_tests. b/218420648 Change-Id: Iccf6bc3843fa12796a2a54ec8b16e49da35f7bd9 (cherry picked from commit a40b822) Co-authored-by: v-kryachko <[email protected]>
…ts. (youtube#585) * Fix 30 tests from PlayerComponentsTests testcase in player_filter_tests. b/218420648 Change-Id: Iccf6bc3843fa12796a2a54ec8b16e49da35f7bd9 Former-commit-id: a40b822
b/218420648
Change-Id: Iccf6bc3843fa12796a2a54ec8b16e49da35f7bd9