Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PathServiceTest.Get test #506

Closed

Conversation

victorpasoshnikov
Copy link
Collaborator

Test was modified according to XBOX limitations

b/219026606

Change-Id: Iea811495b50fd29588ba439a955d9522672adb88

@victorpasoshnikov
Copy link
Collaborator Author

CL 226181

@victorpasoshnikov victorpasoshnikov force-pushed the 219026606_1 branch 2 times, most recently from 5bdb7c0 to 2c3377b Compare June 7, 2023 06:51
Test was modified according to XBOX limitations

b/219026606

Change-Id: Iea811495b50fd29588ba439a955d9522672adb88
@kaidokert
Copy link
Member

@TyHolc ping for a review / comments / thoughts ?

@TyHolc
Copy link
Contributor

TyHolc commented Jul 12, 2023

@TyHolc ping for a review / comments / thoughts ?

If we're sure this will be non-disruptive to other platforms by expanding the scope of "does this path exist" to include directories, then I'm fine with this.

An alternative could be:

#if defined(OS_WIN)
  if (dir_type == <LocalFolder> || dir_type == <LocalCacheFolder> || dir_type == <etc>...) {
    if (!DirectoryExists(path)) {
      return false;
    }
    check_path_exists = false;
  }
#endif

@TyHolc
Copy link
Contributor

TyHolc commented Nov 21, 2023

I'm going to leave this test disabled on Xbox for now and close this. Skipping this test with test filters for xbox is preferable to me over having all platforms skip checking their implementation of Get for their respective home directories.

@TyHolc TyHolc closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants