Add ScopedJobThreadPtr class to be used with JobThread #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
reviewed
Oct 17, 2024
alexanderbobrovnik
force-pushed
the
b3725
branch
from
67a8d3b
to
30e7e60
Compare
alexanderbobrovnik
changed the title
|
@borongc is it possible for you to help me review the part in this PR where all changes to Schedule() made during the scoped_ptr<> to unique_ptr<> migration is reverted? |
xiaomings
reviewed
Oct 22, 2024
alexanderbobrovnik
force-pushed
the
b3725
branch
from
30e7e60
to
5a37123
Compare
amurovanyi
approved these changes
Oct 31, 2024
jellefoks
reviewed
Nov 6, 2024
jellefoks
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/372515171