Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors encountered by some compilers #4114

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix build errors encountered by some compilers #4114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions starboard/shared/pthread/thread_priority.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ int SbPriorityToNice(SbThreadPriority priority) {
case kSbThreadPriorityRealTime:
return -19;
}
return 0;
}

SbThreadPriority NiceToSbPriority(int nice) {
Expand All @@ -56,6 +57,7 @@ SbThreadPriority NiceToSbPriority(int nice) {
if (nice == -19) {
return kSbThreadPriorityRealTime;
}
return kSbThreadPriorityNormal;
}

} // namespace
Expand Down
2 changes: 1 addition & 1 deletion third_party/crashpad/crashpad/client/crash_report_database_generic.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ OperationStatus CrashReportDatabaseGeneric::RemoveOldReports(
all_reports.end(), completed_reports.begin(), completed_reports.end());
std::sort(all_reports.begin(), all_reports.end(), WasCreatedSooner);

while (all_reports.size() > num_reports_to_keep) {
while (all_reports.size() > static_cast<unsigned int>(num_reports_to_keep)) {
OperationStatus os = DeleteReport((*all_reports.begin()).uuid);
if (os != kNoError) {
return os;
Expand Down
2 changes: 1 addition & 1 deletion third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ void ProcessSnapshotLinux::InitializeModules(
}

std::vector<uint8_t> build_id(evergreen_info.build_id_length);
for (int i = 0; i < build_id.size(); i++) {
for (unsigned int i = 0; i < build_id.size(); i++) {
build_id[i] = reinterpret_cast<uint8_t*>(evergreen_info.build_id)[i];
}

Expand Down
Loading