Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated starboard header files #4106

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Delete deprecated starboard header files #4106

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fdd5464
Delete deprecated starboard header files
madhurajayaraman Sep 11, 2024
fb8015f
Delete directory header file
madhurajayaraman Sep 11, 2024
f4c3388
Delete mutex header file
madhurajayaraman Sep 11, 2024
c8a8227
Delete string and condition_variable header file
madhurajayaraman Sep 11, 2024
4fa8d7f
Remove hanging references to starboard/file.h
madhurajayaraman Sep 12, 2024
8e2ffbd
Remove whitespace
madhurajayaraman Sep 12, 2024
457f381
Remaining whitespace changes
madhurajayaraman Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/files/file_enumerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#if defined(STARBOARD)
#include <sys/stat.h>
#include <unistd.h>
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#elif BUILDFLAG(IS_WIN)
#include "base/win/windows_types.h"
#elif BUILDFLAG(IS_POSIX) || BUILDFLAG(IS_FUCHSIA)
Expand Down
3 changes: 1 addition & 2 deletions base/files/file_enumerator_starboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/memory.h"

namespace base {
Expand Down
2 changes: 1 addition & 1 deletion base/files/file_starboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include "base/strings/stringprintf.h"
#include "base/threading/thread_restrictions.h"
#include "starboard/common/metrics/stats_tracker.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved

namespace base {

Expand Down
1 change: 0 additions & 1 deletion base/files/file_util_starboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "base/time/time.h"
#include "starboard/configuration_constants.h"
#include "starboard/common/file.h"
#include "starboard/directory.h"
#include "base/strings/strcat.h"
#include "starboard/system.h"

Expand Down
2 changes: 1 addition & 1 deletion base/files/platform_file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "build/build_config.h"

#if defined(STARBOARD)
madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/file.h"

#endif

#if BUILDFLAG(IS_WIN)
Expand Down
2 changes: 1 addition & 1 deletion base/files/scoped_file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include "build/build_config.h"

#if defined(STARBOARD)
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/types.h"
#include "starboard/common/file.h"
#endif
Expand Down
2 changes: 1 addition & 1 deletion base/logging.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
#include "starboard/common/time.h"
#include "starboard/configuration.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/system.h"
typedef int* FileHandle;
typedef pthread_mutex_t MutexHandle;
Expand Down
2 changes: 1 addition & 1 deletion base/memory/platform_shared_memory_handle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include "base/files/scoped_file.h"
#elif defined(STARBOARD)
#include "base/files/scoped_file.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#endif

namespace base::subtle {
Expand Down
3 changes: 1 addition & 2 deletions chrome/updater/util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
#include "crypto/sha2.h"
#include "starboard/configuration_constants.h"
#include "starboard/extension/installation_manager.h"
#include "starboard/file.h"
#include "starboard/string.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/system.h"

#define PRODUCT_FULLNAME_STRING "cobalt_updater"
Expand Down
1 change: 0 additions & 1 deletion chrome/updater/utils_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include "base/strings/strcat.h"
#include "base/values.h"
#include "gmock/gmock.h"
#include "starboard/directory.h"
#include "starboard/extension/installation_manager.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion cobalt/browser/memory_settings/pretty_print_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "cobalt/browser/memory_settings/test_common.h"
#include "cobalt/browser/switches.h"
#include "starboard/memory.h"
#include "starboard/string.h"
#include "starboard/system.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion cobalt/browser/memory_settings/table_printer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "cobalt/browser/memory_settings/table_printer.h"

#include "base/logging.h"
#include "starboard/string.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace cobalt {
Expand Down
1 change: 0 additions & 1 deletion cobalt/browser/splash_screen_cache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include "cobalt/base/get_application_key.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"

namespace cobalt {
namespace browser {
Expand Down
1 change: 0 additions & 1 deletion cobalt/cache/memory_capped_directory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/strings/string_number_conversions.h"
#include "starboard/directory.h"

namespace cobalt {
namespace cache {
Expand Down
1 change: 0 additions & 1 deletion cobalt/configuration/configuration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/logging.h"
#include "base/memory/singleton.h"
#include "starboard/common/configuration_defaults.h"
#include "starboard/string.h"
#include "starboard/system.h"

namespace cobalt {
Expand Down
1 change: 0 additions & 1 deletion cobalt/debug/console/command_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <cstring>

#include "base/logging.h"
#include "starboard/string.h"

namespace cobalt {
namespace debug {
Expand Down
1 change: 0 additions & 1 deletion cobalt/dom/navigator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "cobalt/web/navigator_base.h"
#include "cobalt/worker/service_worker_container.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/media.h"

namespace cobalt {
Expand Down
2 changes: 1 addition & 1 deletion cobalt/dom/window.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
#include "cobalt/web/environment_settings_helper.h"
#include "cobalt/web/event.h"
#include "cobalt/web/window_or_worker_global_scope.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved

using cobalt::cssom::ViewportSize;
using cobalt::media_session::MediaSession;
Expand Down
2 changes: 1 addition & 1 deletion cobalt/loader/image/jpeg_image_decoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "base/callback.h"
#include "cobalt/loader/image/image.h"
#include "cobalt/loader/image/image_data_decoder.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved

// Inhibit C++ name-mangling for libjpeg functions.
extern "C" {
Expand Down
1 change: 0 additions & 1 deletion cobalt/media/sandbox/fuzzer_app.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"

namespace cobalt {
namespace media {
Expand Down
2 changes: 1 addition & 1 deletion cobalt/network/dial/dial_system_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "net/base/net_string_util.h"

#if defined(STARBOARD)
#include "starboard/string.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/types.h"
#endif

Expand Down
1 change: 0 additions & 1 deletion cobalt/renderer/backend/graphics_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include "base/logging.h"
#include "starboard/gles.h"
#include "starboard/string.h"

namespace cobalt {
namespace renderer {
Expand Down
1 change: 0 additions & 1 deletion cobalt/renderer/rasterizer/skia/skia/src/ports/SkFontMgr_cobalt.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "cobalt/renderer/rasterizer/skia/skia/src/ports/SkFreeType_cobalt.h"
#include "cobalt/renderer/rasterizer/skia/skia/src/ports/SkTypeface_cobalt.h"
#include "starboard/extension/font.h"
#include "starboard/string.h"
#include "third_party/icu/source/common/unicode/locid.h"

const char* ROBOTO_SCRIPT = "latn";
Expand Down
1 change: 0 additions & 1 deletion cobalt/script/v8c/isolate_fellowship.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include "cobalt/script/v8c/switches.h"
#include "cobalt/script/v8c/v8c_tracing_controller.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/memory.h"

namespace cobalt {
Expand Down
2 changes: 1 addition & 1 deletion components/update_client/cobalt_slot_management.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "chrome/updater/util.h"
#include "components/update_client/utils.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/loader_app/app_key_files.h"
#include "starboard/loader_app/drain_file.h"

Expand Down
5 changes: 2 additions & 3 deletions net/cert/internal/trust_store_in_memory_starboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@
#include "net/cert/x509_util.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/file.h"
#include "starboard/string.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved

#include "third_party/boringssl/src/include/openssl/digest.h"
#include "third_party/boringssl/src/include/openssl/sha.h"
#include "third_party/boringssl/src/include/openssl/x509.h"
Expand Down
1 change: 0 additions & 1 deletion .../quiche/src/quiche/common/platform/default/quiche_platform_impl/quiche_file_utils_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <unistd.h>

#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#elif defined(_WIN32)
#include <windows.h>
#else
Expand Down
24 changes: 0 additions & 24 deletions starboard/accessibility.h
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions starboard/android/shared/android_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
#include "starboard/common/semaphore.h"
#include "starboard/common/string.h"
#if SB_IS(EVERGREEN_COMPATIBLE)
#include "starboard/directory.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#endif
#include "starboard/event.h"
#include "starboard/log.h"
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/file_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#include <android/asset_manager.h>

#include "starboard/file.h"
#include "starboard/shared/internal_only.h"

struct SbFilePrivate {
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/media_is_supported.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "starboard/android/shared/media_common.h"
#include "starboard/media.h"
#include "starboard/shared/starboard/media/mime_type.h"
#include "starboard/string.h"

bool SbMediaIsSupported(SbMediaVideoCodec video_codec,
SbMediaAudioCodec audio_codec,
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/player_create.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include "starboard/shared/starboard/player/filter/filter_based_player_worker_handler.h"
#include "starboard/shared/starboard/player/player_internal.h"
#include "starboard/shared/starboard/player/player_worker.h"
#include "starboard/string.h"

using starboard::shared::starboard::player::PlayerWorker;
using starboard::shared::starboard::player::filter::
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/player_get_preferred_output_mode.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "starboard/configuration.h"
#include "starboard/shared/starboard/media/media_util.h"
#include "starboard/shared/starboard/player/filter/player_components.h"
#include "starboard/string.h"

SbPlayerOutputMode SbPlayerGetPreferredOutputMode(
const SbPlayerCreationParam* creation_param) {
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/posix_emu/file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "starboard/android/shared/file_internal.h"
#include "starboard/common/log.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/log.h"

using starboard::android::shared::AssetManager;
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/posix_emu/stat.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

#include "starboard/android/shared/file_internal.h"
#include "starboard/common/log.h"
#include "starboard/directory.h"

using starboard::android::shared::IsAndroidAssetPath;
using starboard::android::shared::OpenAndroidAsset;
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/system_get_path.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "starboard/android/shared/file_internal.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/directory.h"

#if SB_IS(EVERGREEN_COMPATIBLE)
#include "starboard/elf_loader/evergreen_config.h" // nogncheck
Expand Down
2 changes: 1 addition & 1 deletion starboard/android/shared/video_decoder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include "starboard/memory.h"
#include "starboard/shared/starboard/media/mime_type.h"
#include "starboard/shared/starboard/player/filter/video_frame_internal.h"
#include "starboard/string.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/thread.h"

namespace starboard {
Expand Down
25 changes: 0 additions & 25 deletions starboard/byte_swap.h
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion starboard/client_porting/icu_init/icu_init.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "starboard/common/once.h"
#include "starboard/configuration.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/system.h"
#include "third_party/icu/source/common/unicode/putil.h"
#include "third_party/icu/source/common/unicode/udata.h"
Expand Down
1 change: 0 additions & 1 deletion starboard/common/condition_variable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include <pthread.h>

#include "starboard/common/mutex.h"
#include "starboard/condition_variable.h"
#include "starboard/configuration.h"
#include "starboard/types.h"

Expand Down
1 change: 0 additions & 1 deletion starboard/common/experimental/concurrency_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "starboard/common/log.h"
#include "starboard/common/time.h"
#include "starboard/configuration_constants.h"
#include "starboard/mutex.h"
#include "starboard/thread.h"

// WARNING: Features inside experimental namespace is strictly experimental and
Expand Down
4 changes: 1 addition & 3 deletions starboard/common/file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@
#include "starboard/common/metrics/stats_tracker.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/file.h"

madhurajayaraman marked this conversation as resolved.
Show resolved Hide resolved
#include "starboard/shared/starboard/file_atomic_replace_write_file.h"
#include "starboard/string.h"

namespace starboard {
namespace {
Expand Down
Loading
Loading