-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[telemetry] Add telemetry to SbMedia functions #4101
Conversation
712ec51
to
d669f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I don't think your PR description of ranges matches what the histogram ranges actually are.
This is a very conservative range, as we saw in production, a simple getter function, like Moreover, if they are actually in the order of few microseconds, it should be fine because it indicates that it is not critical to improve them at this moment. If we use the range of [1us, 5ms], it can still capture the range. In other words, it is okay for right-skewed histogram for us, but we cannot accept the left-skewed histogram. |
80ae39c
to
6b4c068
Compare
Adding additional Media Telemetry to cover SbMedia functions. The rough range of each function: 1. SbMediaIsBufferPoolAllocateOnDemand(): 1us to 2us 2. SbMediaGetInitialBufferCapacity(): 1us to 2us 3. SbMediaGetBufferAllocationUnit(): 1us to 2us b/303328238
6b4c068
to
aff090f
Compare
This reverts commit 914a1b7.
Adding additional Media Telemetry to cover SbMedia functions.
The rough range of each function:
SbMediaGetProgressiveBufferBudget() should be expected to be similar to SbMediaGetVideoBufferBudget().
b/303328238