Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for SB_API_VERSION < 17 checks #4098

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Cleanup for SB_API_VERSION < 17 checks #4098

merged 1 commit into from
Sep 12, 2024

Conversation

madhurajayaraman
Copy link
Contributor

b/362374622

@madhurajayaraman
SB_API_VERSION variable cleanup for media files
673bf28 
b/362374622

Change-Id: I0240d2cdfb83eb6f0184779d2c486d3ea62880b1
@madhurajayaraman madhurajayaraman marked this pull request as ready for review September 11, 2024 18:31
niranjanyardi
niranjanyardi requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we also removing the variable "sb_api_version" from base_configuration.gni ? and the corresponding SB_API_VERSION definition in starboard/build/config/sabi ? Might be good to add yavor to reviewers in that case.

@madhurajayaraman
Copy link
Contributor Author

are we also removing the variable "sb_api_version" from base_configuration.gni ? and the corresponding SB_API_VERSION definition in starboard/build/config/sabi ? Might be good to add yavor to reviewers in that case.

@niranjanyardi -- the PR descriptor is bad, I'll update it! I'm removing checks like #if SB_API_VERSION >= 15 since everything is on 17 on trunk now.

@madhurajayaraman madhurajayaraman changed the title SB_API_VERSION variable cleanup Cleanup for SB_API_VERSION < 17 checks Sep 11, 2024
@madhurajayaraman madhurajayaraman merged commit 6d0800e into youtube:main Sep 12, 2024
268 of 270 checks passed
@madhurajayaraman madhurajayaraman deleted the cleanup branch September 12, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niranjanyardi niranjanyardi niranjanyardi approved these changes

Assignees
No one assigned
Labels
on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhurajayaraman @niranjanyardi