Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge origin/main (#4005) #4078

Merged

Conversation

niranjanyardi
Copy link
Contributor

b/360216121

Merge origin/main periodically


Co-authored-by: Madhura Jayaraman [email protected]
Co-authored-by: MSoliankoLuxoft [email protected]
Co-authored-by: Hao [email protected]
Co-authored-by: Jelle Foks [email protected]
Co-authored-by: Oscar Vestlie [email protected]
Co-authored-by: Yijia Zhang [email protected]
Co-authored-by: Kaido Kert [email protected]
Co-authored-by: Colin Liang [email protected]
Co-authored-by: Colin Liang [email protected]
Co-authored-by: xiaomings [email protected]
Co-authored-by: iuriionishchenko [email protected]

madhurajayaraman and others added 30 commits August 9, 2024 00:19
Set up a custom stack size for the web module creation process. On
certain platforms, the default stack size is insufficient, leading to
stack overflow issues.

b/357525935
This turns of the compiler flag for optimizing for size, so that it's
optimizing for speed instead.

b/348717754
b/302715109

Test-On-Device: true
Changes the default RFC3484 address ordering to prefer IPv4 for current
versions of Cobalt. This restores the behavior in prior Cobalt versions.

Test-on-device: True

b/359376180
This adds a command-line switch `disable_h2` that disables the HTTP/2
protocol (spdy), and a matching `h5vcc.settings` parameter 'HTTP2' (with
backing by `PersistentSettings`) for run-time disabling of HTTP/2 and
spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect
immediately for new connections only.

This also ensures that when the command-line parameter `disable_quic` or
the new `disable_h2` is used, that that can not be overuled later with
`5vcc.settings` or from the corresponding `PersistentSetting`.

b/205134049
The files were added in youtube#3707

b/347963541

Change-Id: Ibab302808d5373759606898bf4c451385aed400a

Co-authored-by: Colin Liang <[email protected]>
When started with `--debug_console=off`, don't
start the DebugConsole at all.

Note: The web debugger (devtools) still works but
no longer will show overlay changes. To also
disable the web debugger, also start with
`--disable_web_debugger`.

b/205134049
Move platform related source code (e.g. CaptionSettings.java,
CobaltMediaSession.java) from dev/cobalt/media to dev/cobalt/coat. There
are no functional changes otherwise.

Some features are mostly used during video playback, like the
MediaSession where the playback control and status is displayed during
playback, are really platform features.

Their implementations were placed in the media/ folder due to legacy
reasons. This PR move them back to the coat folder, where other platform
implementations stay.

b/345542000
Code clean up to remove starboard/common/atomic usage

Test-On-Device: true

b/353387554
b/358459975

Removes xb1, win32 builders from github
b/358518924

Change-Id: I7387756a3769d60595a86c29a7b6aa2afdd9385f
This reverts behavior to 24.lts standards.

b/359594600
Adds GN code to always build BoringSSL test tool

b/360241262
b/360039566

Change-Id: If8c30563421d3cb925f7c04240bcbf85f54d0a4e
This value, in combination with the existing `totalJSHeapSize` and
`usedJSHeapSize` values, can help describe memory usage of a webpage.

See the MDN reference:

https://developer.mozilla.org/en-US/docs/Web/API/Performance/memory#value

b/355487905
The builders are removed, removing from status view too

b/358459975
madhurajayaraman and others added 13 commits August 22, 2024 11:26
Also clean up some unused Docker images.

b/359451816
b/355184050
b/354270960
max_output_buffers_lookup_table.* are renamed to
max_media_codec_output_buffers_lookup_table.* to reflect the name of
class they implement (i.e. MaxMediaCodecOutputBuffersLookupTable).

b/361864042
It was missing.  It didn't cause any build issues as it's a header file.

b/361864042
Adding additional Media Telemetry to cover SbPlayer DRM functions.

The rough range of each function:
1. SbDrmDestroySystem(): 3.77ms to 111.17ms
2. SbDrmGenerateSessionUpdateRequest(): 32.33ms to 338.9ms
3. SbDrmUpdateSession(): 13.29ms to 267.52ms
4. SbDrmCloseSession(): 2.9ms to 23.71ms

This is the same CL as youtube#4048.

b/303328238
b/362832051

Change-Id: Ie4b48ec398283fca24ee552e6188b13530f1bed3
Adding additional Media Telemetry to cover SbPlayer DRM functions.

The rough range of each function:
1. SbDrmCreateSystem(): 26.307ms to 94.221ms

b/303328238
Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:
1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
2. SbPlayerSeek(): 6us to 318us
3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
5. SbPlayerSetBounds(): 133us to 26.95ms
6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
7. SbPlayerSetVolume(): 7us to 17.89ms
8. SbPlayerGetInfo(): 1us to 6.8ms
9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238
@niranjanyardi niranjanyardi requested review from a team and joeltine as code owners August 30, 2024 21:05
@niranjanyardi niranjanyardi requested review from dahlstrom-g and removed request for a team August 30, 2024 21:05
Change-Id: I47e55a19beaca6651d6a929af5a4e7f019571bd8
Copy link
Contributor Author

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaidokert / @dahlstrom-g / @briantting can you ptal at this commit "Complex manual merge" ?

I accepted all incoming changes and went over them once - and it looked ok to me.

Might be good to get another eye on this

@niranjanyardi niranjanyardi requested review from kaidokert and briantting and removed request for joeltine August 30, 2024 21:20
Change-Id: I1a8fda60293c95cc0adec83af25561f792dde9eb
@niranjanyardi niranjanyardi merged commit 708c7ab into youtube:feature/sb17 Aug 30, 2024
301 checks passed
@niranjanyardi niranjanyardi deleted the update_sb17_with_merge branch August 30, 2024 23:56
madhurajayaraman added a commit to madhurajayaraman/cobalt that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.