Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocolfilter setting to set overriding protocols for an origin. #4065

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add protocolfilter setting to set overriding protocols for an origin. #4065

merged 1 commit into from
Aug 30, 2024

Conversation

aee-google
Copy link
Contributor

@aee-google aee-google commented Aug 29, 2024 •
edited
Loading

b/205134049

@aee-google aee-google marked this pull request as ready for review August 29, 2024 09:29
jellefoks
jellefoks requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@jellefoks jellefoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for making this so quickly!

net/http/http_stream_factory_job_controller.cc Outdated Show resolved Hide resolved
jellefoks
jellefoks approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@jellefoks jellefoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@aee-google aee-google force-pushed the alt-svc branch 3 times, most recently from bb126f1 to 8eafa76 Compare August 29, 2024 22:48
@jellefoks
Copy link
Member

Nice. With a manual test this last version works as expected.

jellefoks
jellefoks approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@jellefoks jellefoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one comment for an early return.

cobalt/h5vcc/h5vcc_settings.cc Show resolved Hide resolved
@kaidokert kaidokert merged commit 9bce406 into youtube:25.lts.1+ Aug 30, 2024
299 checks passed
@aee-google aee-google deleted the alt-svc branch August 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

@jellefoks jellefoks jellefoks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aee-google @jellefoks @kaidokert