Make nplb build in default target #4057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
from
d4a643b
to
80ce1ba
Compare
niranjanyardi
requested review from
jonastsai and
oxve
and removed request for
a team,
joeltine,
johnxwork,
jonastsai and
oxve
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
2 times, most recently
from
f758a30
to
4a81f52
Compare
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
from
4a81f52
to
32d51ce
Compare
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
from
32d51ce
to
55efd63
Compare
Change-Id: I433a8b7d4bd8054600c74daa12180ada11a443bc
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
3 times, most recently
from
162b214
to
dea5ca6
Compare
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
2 times, most recently
from
c09b264
to
4c82597
Compare
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
4 times, most recently
from
86bacbe
to
5c6ed35
Compare
niranjanyardi
force-pushed
the
make_nplb_build_in_default_25lts
branch
from
5c6ed35
to
302855e
Compare
|
not working on this atm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/356067446
We plan on releasing nplb evergreen binaries to partners. This change adds it to the default target which gets currently built on github.
Remove
testonlyvariable for nplb and it's dependencies.Fix missing deps in
nplb