Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation ai_addrlen in PosixSocketResolveTest #4022

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

MSoliankoLuxoft
Copy link
Collaborator

Enhanced the SunnyDay test in PosixSocketResolveTest to include checks for the ai_addrlen field. The test now verifies that ai_addrlen matches the expected size for sockaddr_in (IPv4) and sockaddr_in6 (IPv6) based on the ai_family value. This ensures that getaddrinfo correctly sets the length of the returned socket address structures.

b/349469318

@niranjanyardi niranjanyardi requested review from maxz-lab and removed request for niranjanyardi August 31, 2024 00:11
@maxz-lab maxz-lab enabled auto-merge (squash) September 7, 2024 16:51
auto-merge was automatically disabled September 9, 2024 12:04

Head branch was pushed to by a user without write access

Enhanced the SunnyDay test in PosixSocketResolveTest to include checks
for the ai_addrlen field. The test now verifies that ai_addrlen matches
the expected size for sockaddr_in (IPv4) and sockaddr_in6 (IPv6) based
on the ai_family value. This ensures that getaddrinfo correctly
sets the length of the returned socket address structures.

b/349469318

Signed-off-by: Mykola Solianko <[email protected]>
@MSoliankoLuxoft
Copy link
Collaborator Author

According to the CI, some tests randomly fail even though they are not related to the commit itself. For example, in one CI build, the following test failed:
linux / linux-gcc-6-3 / gcc-6-3_3_test (pull_request) Failing after 5m.
This test was not even related to the committed changes. After re-triggering the CI build, the same test passed successfully:
linux / linux-gcc-6-3 / gcc-6-3_3_test (pull_request) Successful in 6m.
However, another test started to fail:
evergreen / evergreen-x64 / x64_2_test (pull_request) Failing after 10m,
but the test directly related to the commit passed without any issues:

2024-09-09T15:08:35.1359317Z [----------] 7 tests from PosixSocketResolveTest
2024-09-09T15:08:35.1359728Z [ RUN      ] PosixSocketResolveTest.SunnyDay
2024-09-09T15:08:35.1762355Z [       OK ] PosixSocketResolveTest.SunnyDay (40 ms)

@maxz-lab maxz-lab merged commit 8243f46 into youtube:main Sep 9, 2024
353 of 355 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants