Fix deadlock caused by timeout overflow #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/346812667 Change-Id: I9fd9ba7652a1aaee9d748c2dee60cb57b59d4cda Change-Id: I48e03ebc80e441619a0131dd62917016b986f925
y4vor
approved these changes
Aug 15, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
b/346812667 (cherry picked from commit abc3419)
kaidokert
pushed a commit
that referenced
this pull request
Sep 21, 2024
Refer to the original PR: #3998 b/346812667 b/368560498 b/368244422 Co-authored-by: Hao <[email protected]>
jellefoks
reviewed
Sep 23, 2024
| @@ -66,13 +66,24 @@ bool ConditionVariable::WaitTimed(int64_t duration) const { | |||
| bool was_signaled = SbConditionVariableIsSignaled( | |||
| SbConditionVariableWaitTimed(&condition_, mutex_->mutex(), duration)); | |||
| #else | |||
| if (duration < 0) { | |||
There was a problem hiding this comment.
This appears to address a symptom of a bug outside of this function.
If this ever is negative, then the caller is doing something wrong. Adding additional checks here makes every call to this function slower, and it is part of the critical path on some places where performance is critical. I would suggest making the fix outside of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/346812667