Don't start DebugConsole with debug_console=off. #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`.
Datadog ReportBranch report: ✅ 0 Failed, 34451 Passed, 6 Skipped, 10m 6.07s Total Time |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jellefoks
added
cp-20.lts.1+
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`. b/205134049 (cherry picked from commit a9495fe)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`. b/205134049 (cherry picked from commit a9495fe)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`. b/205134049 (cherry picked from commit a9495fe)
This was referenced Aug 15, 2024
jellefoks
added a commit
that referenced
this pull request
Aug 15, 2024
#3995) Refer to the original PR: #3989 When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`. b/205134049 Co-authored-by: Jelle Foks <[email protected]>
kaidokert
pushed a commit
that referenced
this pull request
Aug 15, 2024
#3996) Refer to the original PR: #3989 When started with `--debug_console=off`, don't start the DebugConsole at all. Note: The web debugger (devtools) still works but no longer will show overlay changes. To also disable the web debugger, also start with `--disable_web_debugger`. b/205134049 --------- Co-authored-by: Jelle Foks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When started with
--debug_console=off, don'tstart the DebugConsole at all.
Note: The web debugger (devtools) still works but
no longer will show overlay changes. To also
disable the web debugger, also start with
--disable_web_debugger.b/205134049