Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands to build Cobalt library locally #3855

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add commands to build Cobalt library locally #3855

merged 1 commit into from
Aug 2, 2024

Conversation

jonastsai
Copy link
Contributor

b/318730771

hlwarriner
hlwarriner requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@hlwarriner hlwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

cobalt/site/docs/development/setup-android.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-android.md Outdated Show resolved Hide resolved
cobalt/site/docs/development/setup-android.md Outdated Show resolved Hide resolved
@jonastsai jonastsai marked this pull request as ready for review August 1, 2024 15:15
lamdbui
lamdbui requested changes Aug 1, 2024
View reviewed changes
Copy link

@lamdbui lamdbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this, Jonas! I added just one minor suggestion to link the prebuilt binaries.

cobalt/site/docs/development/setup-android.md Outdated Show resolved Hide resolved
lamdbui
lamdbui approved these changes Aug 2, 2024
View reviewed changes
Copy link

@lamdbui lamdbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jonastsai jonastsai merged commit 98a0b5e into youtube:main Aug 2, 2024
318 of 322 checks passed
@oxve oxve added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Sep 19, 2024
oxve pushed a commit that referenced this pull request Sep 19, 2024
@jonastsai @oxve
Add commands to build Cobalt library locally (#3855)
026f803 
b/318730771
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 19, 2024
@jonastsai @anonymous1-me
Add commands to build Cobalt library locally (#3855)
11be372 
b/318730771

(cherry picked from commit 98a0b5e)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Sep 19, 2024
Closed
@oxve oxve mentioned this pull request Sep 19, 2024
Merged
oxve pushed a commit that referenced this pull request Sep 19, 2024
@cobalt-github-releaser-bot @jonastsai
Cherry pick PRs #3699, #3855 and #4108: EG Doc improvements (#4131)
d67f9f6 
Refer to the original PRs:
* #3699
* #3855
* #4108

b/318730771
b/361540371
b/362655498

---------

Co-authored-by: Jonas Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuying-y yuying-y yuying-y approved these changes

@hlwarriner hlwarriner hlwarriner approved these changes

@lamdbui lamdbui lamdbui approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonastsai @lamdbui @hlwarriner @yuying-y @oxve