Don't optimize for size.

[jellefoks]

This turns of the compiler flag for optimizing for size, so that it's optimizing for speed instead.

b/348717754

[y4vor]

What is the impact on the Evergreen binary size?

[hlwarriner]

What is the impact on the Evergreen binary size?

This change shouldn't impact Evergreen, as for Evergreen the condition results in false both before and after this change.

Actually, I think that by default Evergreen targets are getting compiled with -O2.

Cobalt intends to optimize for size by default, and I believe that's why //starboard/build/config:size is added to default_compiler_configs: https://github.com/youtube/cobalt/blob/main/starboard/build/config/BUILDCONFIG.gn#L164. For Evergreen, this adds the -Os flag.

But default_compiler_configs also adds //build/config/compiler:default_optimization: https://github.com/youtube/cobalt/blob/main/starboard/build/config/BUILDCONFIG.gn#L170. And because optimize_for_size is false for Evergreen, this ends up adding -O2 (instead of -Oz) later in the compilation line: https://github.com/youtube/cobalt/blob/main/build/config/compiler/BUILD.gn#L2267.

Anyway, this may be a bug/regression and opportunity to reduce the size of the Evergreen binaries. Let's have a separate conversation about whether we want the target default to be -Os or -Oz for Evergreen. But I think this PR itself is ok from the Evergreen perspective.

[hlwarriner]

What is the impact on the Evergreen binary size?

This change shouldn't impact Evergreen, as for Evergreen the condition results in false both before and after this change.

Actually, I think that by default Evergreen targets are getting compiled with -O2.

Cobalt intends to optimize for size by default, and I believe that's why //starboard/build/config:size is added to default_compiler_configs: https://github.com/youtube/cobalt/blob/main/starboard/build/config/BUILDCONFIG.gn#L164. For Evergreen, this adds the -Os flag.

But default_compiler_configs also adds //build/config/compiler:default_optimization: https://github.com/youtube/cobalt/blob/main/starboard/build/config/BUILDCONFIG.gn#L170. And because optimize_for_size is false for Evergreen, this ends up adding -O2 (instead of -Oz) later in the compilation line: https://github.com/youtube/cobalt/blob/main/build/config/compiler/BUILD.gn#L2267.

Anyway, this may be a bug/regression and opportunity to reduce the size of the Evergreen binaries. Let's have a separate conversation about whether we want the target default to be -Os or -Oz for Evergreen. But I think this PR itself is ok from the Evergreen perspective.

The Evergreen issue does look like a regression from the Base/Net updates. #2969 made the change, and b/330781200 is also relevant.

[kaidokert]

Please rebase just in case

[jellefoks]

Please rebase just in case

Force pushed to rebase and rerun actions (GitHub UI didn't show a rebase button).