Cherry pick PR #3211: Link ICU data into the Cobalt binary #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, Cobalt will no longer be deployed with an external ICU data file that must be loaded at runtime. b/209049814 Change-Id: I8f67b3176181fa314f3e011ce4cf07fd4a671436 Test-On-Device: true (cherry picked from commit 59d8eaf)
cobalt-github-releaser-bot
requested review from
johnxwork and
hlwarriner
and removed request for
a team
hlwarriner
approved these changes
Jun 7, 2024
|
The evergreen_tests are already failing on on this branch, for example in https://github.com/youtube/cobalt/actions/runs/9415292162. I'll file a bug for that, but the issue is unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3211
With this change, Cobalt will no longer be deployed with an external ICU data file that must be loaded at runtime.
b/209049814
Change-Id: I8f67b3176181fa314f3e011ce4cf07fd4a671436
Test-On-Device: true