Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaup SbFile usage. #3225

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Cleaup SbFile usage. #3225

merged 6 commits into from
Aug 13, 2024

Conversation

yjzhang111
Copy link
Contributor

@yjzhang111 yjzhang111 commented May 10, 2024 •
edited
Loading

b/302715109

Test-On-Device: true

@yjzhang111 yjzhang111 requested a review from a team as a code owner June 27, 2024 23:17
@yjzhang111 yjzhang111 force-pushed the sbfile_cleanup branch 2 times, most recently from b3ace98 to 822bf38 Compare July 1, 2024 23:28
@yjzhang111 yjzhang111 marked this pull request as draft July 9, 2024 18:35
@yjzhang111 yjzhang111 removed the request for review from dahlstrom-g July 9, 2024 18:38
@yjzhang111 yjzhang111 force-pushed the sbfile_cleanup branch 3 times, most recently from f4a917b to 6952922 Compare July 13, 2024 02:37
@yjzhang111 yjzhang111 force-pushed the sbfile_cleanup branch 3 times, most recently from 951c36a to ab7356c Compare July 18, 2024 00:22
@yjzhang111 yjzhang111 force-pushed the sbfile_cleanup branch 5 times, most recently from b41db5b to 89e0160 Compare August 1, 2024 17:31
@yjzhang111 yjzhang111 marked this pull request as ready for review August 2, 2024 17:25
y4vor
y4vor approved these changes Aug 8, 2024
View reviewed changes
starboard/common/file_wrapper.cc Outdated Show resolved Hide resolved
starboard/common/file_wrapper.h Show resolved Hide resolved
third_party/musl/src/starboard/sys/stat.c Outdated Show resolved Hide resolved
@yjzhang111
Cleaup SbFile usage.
73e71ba 
Change-Id: Ie0da2d423cb30500608fc434f3d30805174c3945
@yjzhang111
Cleanup ScopedFile()
c9b54c7
@yjzhang111
Clean up SbFile references.
e32199e
@yjzhang111
Deprecate SbFile APIs.
938e702 
Change-Id: I7e7fccdad5c5d1ecec03e09920dc96ef65ee490e
@yjzhang111
Fix Android file and stat wrapper.
9bfe8ab 
Change-Id: I6f4e922c73d8a2fc32c9da0ab8e97a780cf635be
yjzhang111
yjzhang111 commented Aug 12, 2024
View reviewed changes
Copy link
Contributor Author

@yjzhang111 yjzhang111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this giant PR! PTAL at the unresolved comments.

third_party/boringssl/src/crypto/bio/file.c Show resolved Hide resolved
third_party/boringssl/src/crypto/bio/file.c Outdated Show resolved Hide resolved
third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h Show resolved Hide resolved
starboard/shared/starboard/player/video_dmp_writer.cc Outdated Show resolved Hide resolved
starboard/nplb/posix_compliance/posix_file_mode_string_to_flags_test.cc Outdated Show resolved Hide resolved
@yjzhang111
Address comments.
dc89c35 
Change-Id: I7fa696fc04657107a972e7306befd9017d4827f3
@yjzhang111 yjzhang111 merged commit 9755f54 into youtube:main Aug 13, 2024
365 of 372 checks passed
@yjzhang111 yjzhang111 deleted the sbfile_cleanup branch August 13, 2024 16:44
@yjzhang111 yjzhang111 added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Aug 13, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 13, 2024
@yjzhang111 @anonymous1-me
Cleaup SbFile usage. (#3225)
2f3f3ff 
b/302715109

Test-On-Device: true
(cherry picked from commit 9755f54)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Aug 13, 2024
Merged
yjzhang111 added a commit that referenced this pull request Aug 15, 2024
@cobalt-github-releaser-bot @yjzhang111
Cherry pick PR #3225: Cleaup SbFile usage. (#3977)
683d47b 
Refer to the original PR: #3225

b/302715109

Test-On-Device: true

---------

Co-authored-by: Yijia Zhang <[email protected]>
Co-authored-by: Yijia Zhang <[email protected]>
yjzhang111 added a commit that referenced this pull request Aug 20, 2024
@yjzhang111
Revert "Cherry pick PR #3225: Cleaup SbFile usage. (#3977)"
3158675 
This reverts commit 683d47b.
yjzhang111 added a commit that referenced this pull request Aug 22, 2024
@yjzhang111
Revert "Cherry pick PR #3225: Cleaup SbFile usage." (#4032)
6dcf641 
Reverts parts of #3977 that contains SB_API_VERSION < 17
macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4vor y4vor y4vor approved these changes

@johnxwork johnxwork johnxwork approved these changes

@haozheng-cobalt haozheng-cobalt haozheng-cobalt approved these changes

Assignees
No one assigned
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjzhang111 @y4vor @johnxwork @haozheng-cobalt