Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link ICU data into the Cobalt binary #3211

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Link ICU data into the Cobalt binary #3211

merged 7 commits into from
Jun 7, 2024

Commits on Jun 5, 2024

  1. Link ICU data into the Cobalt binary 

    With this change, Cobalt will no longer be deployed with an external ICU
data file that must be loaded at runtime.

b/209049814

Change-Id: I8f67b3176181fa314f3e011ce4cf07fd4a671436
    @hlwarriner
    hlwarriner committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    60a8738 View commit details
    Browse the repository at this point in the history

  2. Remove instructions for individual ICU data files 

    Change-Id: I6a168818d31285c9c43b6e6d58128c48066078e8
    @hlwarriner
    hlwarriner committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ad710dc View commit details
    Browse the repository at this point in the history

  3. Make Python 3 fix in asm_to_inline_asm.py 

    Change-Id: Ia906aab5f249c8eb9f4b99f371e2e8f3a6802840
    @hlwarriner
    hlwarriner committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8338bb9 View commit details
    Browse the repository at this point in the history

  4. Reformat to remove whitespace diff vs upstream 

    Change-Id: Ibd723905104aa0c283d7f5eed4f7306612d0bc9d
    @hlwarriner
    hlwarriner committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7d20a38 View commit details
    Browse the repository at this point in the history

  5. Use NASM for the ICU data assembly on win32 

    MSVC doesn't support inline data assembly for win32, so we'll skip that
extra step that's taken in upstream. Instead, we use NASM to assemble
the generated data assembly.

Change-Id: Ibaa542b3ee2d3bba2eacf3bedbc3021793910b33
    @hlwarriner
    hlwarriner committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2f08251 View commit details
    Browse the repository at this point in the history

  6. Fix assembly for PS5 

    Change-Id: I31a7020f4746f21f156e2543751212d753159700
    @hlwarriner
    hlwarriner committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    30fb037 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Try NASM for the data assembly on PS5 

    Change-Id: I9433f450c885db2389e21ffd0601ae43009a672d
    @hlwarriner
    hlwarriner committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9c4fd80 View commit details
    Browse the repository at this point in the history