Cherry pick PR #2387: Remove the option to start crash handler at launch #2835
Conversation
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-2387 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/8547053158 for details. |
|
@yuying-y do you still plan to merge this? It looks like there's just a small merge conflict in |
Just solved the conflict, and rerunning the checks. |
yuying-y
force-pushed
the
cherry-pick-24.lts.1+-2387
branch
from
6642417
to
42c9c94
Compare
There was a problem hiding this comment.
Sorry for the just realizing this, but I'm now thinking it may be best to hold off and not cherry pick this change to 24 LTS. It technically does require a small change in partners' platforms, and we generally don't want to make breaking changes in minor releases. What do you think @yuying-y?
This is a tech debt cleanup. Starting the crash handler when a crash happens instead of when the app starts has been the default behavior. This behavior saves 2-3MB memory that the app consumes. This behavior has been proved reliable. The code to allow the other behavior can be removed. b/242101457 Change-Id: Icc725cb801a72b4635d6104abc8226a6f6323f46 (cherry picked from commit 1c7af63)
yuying-y
force-pushed
the
cherry-pick-24.lts.1+-2387
branch
from
42c9c94
to
cfeae9a
Compare
Sure. Sgtm. |
Refer to the original PR: #2387
This is a tech debt cleanup. Starting the crash handler when a crash happens instead of when the app starts has been the default behavior. This behavior saves 2-3MB memory that the app consumes. This behavior has been proved reliable. The code to allow the other behavior can be removed.
b/242101457
Change-Id: Icc725cb801a72b4635d6104abc8226a6f6323f46