Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for POSIX fstat, lseek, and read. #2602

Merged
merged 9 commits into from
May 3, 2024

Conversation

yjzhang111
Copy link
Contributor

@yjzhang111 yjzhang111 commented Mar 14, 2024

b/302715109

Test-On-Device: true

Change-Id: I4db736278c54cdf1af85ba03836361f68796aa8f

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (a0827ea) to head (d228961).
Report is 286 commits behind head on main.

❗ Current head d228961 differs from pull request most recent head 883c45f. Consider uploading reports for the commit 883c45f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
+ Coverage   58.91%   59.83%   +0.91%     
==========================================
  Files        1822     1830       +8     
  Lines       88753    88564     -189     
==========================================
+ Hits        52289    52990     +701     
+ Misses      36464    35574     -890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

starboard/common/file.cc Outdated Show resolved Hide resolved
@yjzhang111 yjzhang111 force-pushed the yjzhang-sbfileread branch 2 times, most recently from 080e1be to 0a0cdb3 Compare May 2, 2024 16:48
@yjzhang111 yjzhang111 requested a review from y4vor May 2, 2024 19:00
@yjzhang111 yjzhang111 marked this pull request as ready for review May 2, 2024 23:37
b/302715109

Change-Id: I4db736278c54cdf1af85ba03836361f68796aa8f
Change-Id: I10178cc183bfd81b0d30c20db9dd2b7cd46698ea
Change-Id: Ibf6fd9aa98c492fc51d73a4b69c8d66c4a4f1ae6
Change-Id: I543758f16bfc2540592792cb10e25bed1283b6b2
Change-Id: I7b70a6afc0769320e8bd6f06133819b57cbc6163
Change-Id: I4c8469b8655d3618e3221f7a50dea1bcb14ea5f4
Change-Id: I6966eac26431373e6eccd70f9b31386daac5717d
Change-Id: Ie4502c1809d22fcd892f2b5d6887d9ad62f30df1
@yjzhang111 yjzhang111 force-pushed the yjzhang-sbfileread branch 2 times, most recently from 6f655bf to dfe72ba Compare May 3, 2024 10:17
Change-Id: Ic36a4e91072be7148b821183e73f574b0fb38f39
@yjzhang111 yjzhang111 merged commit ca46052 into youtube:main May 3, 2024
339 of 353 checks passed
@yjzhang111 yjzhang111 deleted the yjzhang-sbfileread branch May 3, 2024 21:10
@yjzhang111 yjzhang111 added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label May 7, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 7, 2024
b/302715109

Test-On-Device: true

Change-Id: I4db736278c54cdf1af85ba03836361f68796aa8f
(cherry picked from commit ca46052)
yjzhang111 added a commit to yjzhang111/cobalt that referenced this pull request May 8, 2024
b/302715109

Test-On-Device: true

Change-Id: I4db736278c54cdf1af85ba03836361f68796aa8f
(cherry picked from commit ca46052)
yjzhang111 added a commit that referenced this pull request May 9, 2024
)

Refer to the original PR: #2602

b/302715109

Test-On-Device: true

Change-Id: I4db736278c54cdf1af85ba03836361f68796aa8f

Co-authored-by: Yijia Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch on_device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants