Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete eztime_poem #2308

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Delete eztime_poem #2308

merged 1 commit into from
Jan 26, 2024

Conversation

gbournou
Copy link
Contributor

b/320398326

Test-On-Device: true

b/320398326

Test-On-Device: true
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (460ee30) 58.52% compared to head (a85ce25) 58.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
- Coverage   58.52%   58.50%   -0.02%     
==========================================
  Files        1903     1902       -1     
  Lines       94542    94536       -6     
==========================================
- Hits        55329    55310      -19     
- Misses      39213    39226      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@haozheng-cobalt haozheng-cobalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Garo, I'm not familiar with the client_porting layer, can these be directly removed rather than being gated with starboard version?

@gbournou
Copy link
Contributor Author

Hi Garo, I'm not familiar with the client_porting layer, can these be directly removed rather than being gated with starboard version?

In this particular case, no code remains that includes the files, so they can be directly removed. In earlier CLs, the usages were removed, and we instead relied on adding implementation to musl for older SB versions (so that change effectively had gating on SB version)

@gbournou gbournou merged commit 166d22b into youtube:main Jan 26, 2024
374 of 376 checks passed
@gbournou gbournou deleted the eztime branch January 26, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants