Update ssl certs using pem files from google3. #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantting
force-pushed
the
derp
branch
2 times, most recently
from
c4616cd
to
d792e81
Compare
kaidokert
reviewed
Jan 25, 2024
kaidokert
reviewed
Jan 25, 2024
kaidokert
reviewed
Jan 25, 2024
briantting
force-pushed
the
derp
branch
3 times, most recently
from
3dac9bb
to
9d1a261
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
+ Coverage 58.40% 58.41% +0.01%
==========================================
Files 1902 1902
Lines 94718 94718
==========================================
+ Hits 55316 55331 +15
+ Misses 39402 39387 -15 ☔ View full report in Codecov by Sentry. |
briantting
force-pushed
the
derp
branch
2 times, most recently
from
1d993f8
to
c5019db
Compare
briantting
force-pushed
the
derp
branch
4 times, most recently
from
3db99b3
to
d038138
Compare
briantting
force-pushed
the
derp
branch
2 times, most recently
from
a2576a4
to
cfe4463
Compare
security/cacerts/chrome/roots.pem and security/cacerts/for_connecting_to_google/roots.pem were used. The network BUILD.gn file has also been refactored to support automated updates of the ssl certs. The script used is a temporary manual script that will be the starting point for future automations. b/278599663 b/237420990 b/321242817 Change-Id: I26d56091beadb94e86117cd133cdcde5ed922089
andrewsavage1
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM—maybe see if @kaidokert has any comments on the tests, especially our discussion about the mock test. There might be something easy to do there that I don't know about
kaidokert
approved these changes
Feb 7, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
Update ssl certs using pem files from google3. security/cacerts/chrome/roots.pem and security/cacerts/for_connecting_to_google/roots.pem were used. The network BUILD.gn file has also been refactored to support automated updates of the ssl certs. The script used is a temporary manual script that will be the starting point for future automations. b/278599663 b/237420990 b/321242817 (cherry picked from commit fd65e24)
kaidokert
pushed a commit
that referenced
this pull request
Feb 7, 2024
…2392) Refer to the original PR: #2298 Update ssl certs using pem files from google3. security/cacerts/chrome/roots.pem and security/cacerts/for_connecting_to_google/roots.pem were used. The network BUILD.gn file has also been refactored to support automated updates of the ssl certs. The script used is a temporary manual script that will be the starting point for future automations. b/278599663 b/237420990 b/321242817 Co-authored-by: Brian Ting <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ssl certs using pem files from google3.
security/cacerts/chrome/roots.pem and
security/cacerts/for_connecting_to_google/roots.pem were used. The
network BUILD.gn file has also been refactored to support automated
updates of the ssl certs.
The script used is a temporary manual script that will be the starting
point for future automations.
b/278599663
b/237420990
b/321242817