Add boxdump debug command #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellefoks
force-pushed
the
boxdump
branch
2 times, most recently
from
eed136a
to
7295868
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
==========================================
- Coverage 58.45% 58.44% -0.01%
==========================================
Files 1901 1901
Lines 94607 94669 +62
==========================================
+ Hits 55299 55326 +27
- Misses 39308 39343 +35 ☔ View full report in Codecov by Sentry. |
jellefoks
force-pushed
the
boxdump
branch
4 times, most recently
from
91f8dde
to
9ede2de
Compare
|
What will be the output look like? Can you share an example here? |
|
sherryzy
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "boxdump()" to the debug console commands, that prints the tree of LayoutBoxes with references to the generating element, enabled for qa/devel/debug builds. This also improves the Cobalt tab for debug console commands to use a textarea instead of pre, with a download button, and execute the debug command on "enter" instead of requiring a separate button press.
To make this possible, the |ConsoleCommandManager| is expanded to support a |CommandHandler| that returns a string.
The "dump_render_tree" is also changed to return the tree as a string for devtools.
Ths boxdump is slightly expanded to also print the computed style non-inherited property values for each box, and some internal state for the flex containers.
b/0nobug