Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of no-op POEMs (protobuf) #2228

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Remove usages of no-op POEMs (protobuf) #2228

merged 1 commit into from
Jan 18, 2024

Conversation

gbournou
Copy link
Contributor

@gbournou gbournou commented Jan 17, 2024 •
edited
Loading

  • stdio_poem, string_poem, strings_poem, wchar_poem

b/307941391
b/320764165
b/320764087

@gbournou
Remove usages of no-op POEMs (protobuf)
570debc 
- stdio_poem, string_poem, strings_poem, wchar_poem

b/307941391
dahlstrom-g
dahlstrom-g approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@dahlstrom-g dahlstrom-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a squash commit as a second parent to rehabilitate provenance for these files, or not. It's a subsidiary concern I suppose.

@gbournou
Copy link
Contributor Author

We could add a squash commit as a second parent to rehabilitate provenance for these files, or not. It's a subsidiary concern I suppose.

That's beyond my abilities, so I'll leave that to a separate PR if need be

@gbournou gbournou merged commit a68ae38 into youtube:main Jan 18, 2024
694 of 699 checks passed
@gbournou gbournou deleted the poem branch January 18, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlstrom-g dahlstrom-g dahlstrom-g approved these changes

Assignees
No one assigned
Labels
on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbournou @dahlstrom-g