Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MediaPlaybackService #2212

Merged

Conversation

zhongqiliang
Copy link
Contributor

@zhongqiliang zhongqiliang commented Jan 13, 2024

Submit #2184 again.

Replaced MediaModule mediaModule = MediaModule(nullptr, nullptr); with MediaModule mediaModule(nullptr, nullptr); in cobalt/media/media_module_test.cc.

b/319146388

@zhongqiliang zhongqiliang force-pushed the revert-2211-revert-2184-disable_background_playback branch from 1b2091d to 50d6b08 Compare January 13, 2024 03:26
@zhongqiliang zhongqiliang changed the title Revert "Revert "Disable MediaPlaybackService by default"" Disable MediaPlaybackService Jan 13, 2024
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Jan 13, 2024

Datadog Report

Branch report: revert-2211-revert-2184-disable_background_playback
Commit report: 9d70021
Test service: cobalt

✅ 0 Failed, 29853 Passed, 1 Skipped, 31m 34.7s Wall Time
❄️ 2 New Flaky

New Flaky Tests (2)

  • DrainingSlot/0 - SlotManagementTests/SlotManagementTest - Last Failure

    Expand for error
     ../../starboard/loader_app/slot_management_test.cc:136
     Expected equality of these values:
       exists
         Which is: false
       SbFileExists(bad_app_key_file_path.c_str())
         Which is: true
    
  • DrainingSlot/1 - SlotManagementTests/SlotManagementTest - Last Failure

    Expand for error
     ../../starboard/loader_app/slot_management_test.cc:136
     Expected equality of these values:
       exists
         Which is: false
       SbFileExists(bad_app_key_file_path.c_str())
         Which is: true
    

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1f2d96b) 58.52% compared to head (9d70021) 58.53%.
Report is 21 commits behind head on main.

Files Patch % Lines
cobalt/media/media_module.cc 61.53% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2212   +/-   ##
=======================================
  Coverage   58.52%   58.53%           
=======================================
  Files        1907     1908    +1     
  Lines       94568    94584   +16     
=======================================
+ Hits        55349    55365   +16     
  Misses      39219    39219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongqiliang zhongqiliang enabled auto-merge (squash) January 16, 2024 19:24
@zhongqiliang zhongqiliang force-pushed the revert-2211-revert-2184-disable_background_playback branch from 50d6b08 to 9d70021 Compare January 16, 2024 20:38
auto-merge was automatically disabled January 16, 2024 21:18

Pull Request is not mergeable

@zhongqiliang zhongqiliang merged commit d3cb040 into main Jan 16, 2024
333 of 334 checks passed
@zhongqiliang zhongqiliang deleted the revert-2211-revert-2184-disable_background_playback branch January 16, 2024 23:03
@zhongqiliang zhongqiliang added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 16, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jan 16, 2024
Submit #2184 again.

Replaced `MediaModule mediaModule = MediaModule(nullptr, nullptr);` with
`MediaModule mediaModule(nullptr, nullptr);` in
cobalt/media/media_module_test.cc.

b/319146388

(cherry picked from commit d3cb040)
zhongqiliang added a commit that referenced this pull request Jan 17, 2024
Refer to the original PR: #2212

Submit #2184 again.

Replaced `MediaModule mediaModule = MediaModule(nullptr, nullptr);` with
`MediaModule mediaModule(nullptr, nullptr);` in
cobalt/media/media_module_test.cc.

b/319146388

Co-authored-by: Colin Liang <[email protected]>
borongc pushed a commit to borongc/cobalt that referenced this pull request Apr 9, 2024
Submit youtube#2184 again.

Replaced `MediaModule mediaModule = MediaModule(nullptr, nullptr);` with
`MediaModule mediaModule(nullptr, nullptr);` in
cobalt/media/media_module_test.cc.

b/319146388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants