Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable EG tests after SbTime API deprecation #2203

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

hlwarriner
Copy link
Contributor

These tests are no longer blocking but the failures can still be confusing for Cobalt developers.

b/302733082

Change-Id: I4d546e71ffa13fff4d6fe7f9903dd492de0bedb2

These tests are no longer blocking but the failures can still be confusing
for Cobalt developers.

b/302733082

Change-Id: I4d546e71ffa13fff4d6fe7f9903dd492de0bedb2
@andrewsavage1
Copy link
Contributor

@gbournou I think you were saying that these tests just need to be regenerated?

My only worry with disabling them completely would be that real breakages would go unnoticed and make it harder to integrate the new version of evergreen tests that you're working on, but if that's not a concern for y'all then I don't have an issue with this

@hlwarriner
Copy link
Contributor Author

@gbournou I think you were saying that these tests just need to be regenerated?

My only worry with disabling them completely would be that real breakages would go unnoticed and make it harder to integrate the new version of evergreen tests that you're working on, but if that's not a concern for y'all then I don't have an issue with this

Oh yeah I'm planning to just disable them for a day (or a few...whenever the trunk nightly release succeeds and puts the new binaries up on Omama/Lorry). Sorry, I mentioned that in the todo comment but not in the PR description.

We used to have to temporarily disable the tests when Starboard APIs were changed to unblock the nightly release that puts the new packages up on Omaha/Lorry. We don't need to anymore, since these checks are non-blocking, but we already had a question about the failures in the Cobalt team chat - so just wanted to avoid more confusion.

go/sustainable-eg-tests will fix this but isn't ready yet.

@hlwarriner hlwarriner enabled auto-merge (squash) January 12, 2024 00:48
@hlwarriner hlwarriner merged commit e9cde16 into youtube:main Jan 12, 2024
332 of 333 checks passed
hlwarriner added a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants