Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set evergreen platform tests to use starboard toolchain #2190

Merged
merged 8 commits into from
Jan 10, 2024

Conversation

kaidokert
Copy link
Member

@kaidokert kaidokert commented Jan 10, 2024

These targets are only expected to be built with system/Starboard toolchain.

b/300122871

This target is only expected to be built with system/Starboard
toolchain.

b/300122871
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc372aa) 58.55% compared to head (4f3c7b9) 58.55%.

❗ Current head 4f3c7b9 differs from pull request most recent head eca4595. Consider uploading reports for the commit eca4595 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2190   +/-   ##
=======================================
  Coverage   58.55%   58.55%           
=======================================
  Files        1909     1909           
  Lines       94580    94580           
=======================================
+ Hits        55385    55386    +1     
+ Misses      39195    39194    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsavage1
Copy link
Contributor

@kaidokert I won't be able to add you as a reviewer but please also take a look at this before it goes in

@andrewsavage1 andrewsavage1 changed the title Set elf_loader_test to starboard toolchain Set evergreen platform tests to use starboard toolchain Jan 10, 2024
@andrewsavage1 andrewsavage1 merged commit 30fbc6b into youtube:main Jan 10, 2024
381 of 393 checks passed
@kaidokert kaidokert deleted the elfloader branch June 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants