Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abseil at Chrome tag m114.0.5735.331 #2179

Closed
wants to merge 2 commits into from

Conversation

andrewsavage1
Copy link
Contributor

@andrewsavage1 andrewsavage1 commented Jan 8, 2024

b/319139474

@andrewsavage1 andrewsavage1 marked this pull request as draft January 8, 2024 22:32
@andrewsavage1
Copy link
Contributor Author

This looks like it will need some more work for this to build for all platforms

@jellefoks
Copy link
Member

This looks like it will need some more work for this to build for all platforms

This may be just need a gn dependency for media to this new copy of abseil, because media already had a copy of absl/types/optional.h and now gn seems to think it wants to use these new files without having a dependency defined to it.

ERROR at //third_party/chromium/media/base/decrypt_config.h:20:11: Include not allowed.
#include "third_party/abseil-cpp/absl/types/optional.h"
          ^-------------------------------------------
It is not in any dependency of
  //third_party/chromium/media:media
The include file is in the target(s):
  //third_party/abseil-cpp/absl/types:optional
which should somehow be reachable.

@andrewsavage1 andrewsavage1 deleted the feature/add-abseil branch March 7, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants