Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize POSIX htonl/ntohl #2166

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Utilize POSIX htonl/ntohl #2166

merged 1 commit into from
Jan 6, 2024

Conversation

gbournou
Copy link
Contributor

@gbournou gbournou commented Jan 5, 2024

  • Fix missing include
  • Remove Starboard customizations to third_party code
  • Prepare for removal of SB_HOST_TO_NET/SB_NET_TO_HOST macros

b/317437129

Test-On-Device: true

Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong here, good cleanup in third_party too.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a4c5c5) 58.56% compared to head (ead8211) 58.57%.
Report is 1 commits behind head on main.

❗ Current head ead8211 differs from pull request most recent head a4e7c49. Consider uploading reports for the commit a4e7c49 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2166    +/-   ##
========================================
  Coverage   58.56%   58.57%            
========================================
  Files        1910     1906     -4     
  Lines       94583    94249   -334     
========================================
- Hits        55395    55203   -192     
+ Misses      39188    39046   -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Fix missing include
- Remove Starboard customizations to third_party code
- Prepare for removal of SB_HOST_TO_NET/SB_NET_TO_HOST macros

b/317437129

Test-On-Device: true
@gbournou gbournou merged commit 9bfdad0 into youtube:main Jan 6, 2024
370 of 374 checks passed
@gbournou gbournou deleted the inet branch January 6, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants