Fix path passing for pre-commit #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
force-pushed
the
kaidokert-break-meta
branch
5 times, most recently
from
d9a3eff
to
9a9148f
Compare
|
Intend to submit the first commit of course only, second one is just to show things working |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
- Coverage 58.56% 58.55% -0.01%
==========================================
Files 1911 1911
Lines 94585 94585
==========================================
- Hits 55391 55387 -4
- Misses 39194 39198 +4 ☔ View full report in Codecov by Sentry. |
dahlstrom-g
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
With commit 9a9148f the meta-validate hook works for me locally.
PR-title nit: https://cbea.ms/git-commit/#end
Also fix filename separators on Windows. b/150775273
kaidokert
changed the title
kaidokert
force-pushed
the
kaidokert-break-meta
branch
from
897ccbf
to
bd081d3
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix filename separators on Windows.
b/150775273