Make posix_time_wrappers a source_set #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I58cc1827d5e213fadb5794b1be47335c6eeef55e
kaidokert
approved these changes
Dec 19, 2023
|
waiting for presubmits to pass go/lbreview/271986 |
y4vor
approved these changes
Dec 19, 2023
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
All starboard symbols which need to be exported must be part of a source_set(not static library) unless this bug for modular PS5 is solved: b/315170518 b/315170518 b/316956094
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
All starboard symbols which need to be exported must be part of a source_set(not static library) unless this bug for modular PS5 is solved: b/315170518 b/315170518 b/316956094 (cherry picked from commit 649c19a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All starboard symbols which need to be exported must be part of a source_set(not static library) unless this bug for modular PS5 is solved: b/315170518
b/315170518
b/316956094