Add log API for non release builds. #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2108 +/- ##
==========================================
- Coverage 58.67% 58.57% -0.11%
==========================================
Files 1907 1914 +7
Lines 94073 94432 +359
==========================================
+ Hits 55199 55313 +114
- Misses 38874 39119 +245 ☔ View full report in Codecov by Sentry. |
The API can prints logs to logcat for Fishfood and Dogfood builds, but not release build, because it is stripped by ProGuard.wq! b/315852240
zhongqiliang
force-pushed
the
add_nonlog_api_for_nonrelease_build
branch
from
c09807e
to
0468f68
Compare
gbournou
approved these changes
Dec 15, 2023
y4vor
approved these changes
Dec 16, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Dec 16, 2023
Make v(),d(),i() logs not print for release builds. These logs still prints for fishfood and dogfood builds. b/315852240 Co-authored-by: Colin Liang <[email protected]> (cherry picked from commit cec32f1)
zhongqiliang
added a commit
that referenced
this pull request
Dec 16, 2023
Refer to the original PR: #2108 Make v(),d(),i() logs not print for release builds. These logs still prints for fishfood and dogfood builds. b/315852240 Co-authored-by: Colin Liang <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Make v(),d(),i() logs not print for release builds. These logs still prints for fishfood and dogfood builds. b/315852240 Co-authored-by: Colin Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make v(),d(),i() logs not print for release builds.
These logs still prints for fishfood and dogfood builds.
b/315852240