Update //build to m114.0.5735.331. #2100

aee-google · 2023-12-14T21:25:18Z

b/313662336

codecov · 2023-12-29T00:45:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc372aa) 58.55% compared to head (ccd55f0) 58.53%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2100      +/-   ##
==========================================
- Coverage   58.55%   58.53%   -0.03%     
==========================================
  Files        1909     1907       -2     
  Lines       94580    94567      -13     
==========================================
- Hits        55385    55351      -34     
- Misses      39195    39216      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrewsavage1 · 2024-01-02T16:20:47Z

Could you please retry the failed tests to ensure they're flakes? Also please test on device and internally

andrewsavage1

Why are so many things outside of //build changing in this PR? The update should only affect that directory and possibly direct references to it, but there's a lot of other things going on here

build_overrides/util/is_python2.py

Change-Id: Id47a9e956f64ee29344e5d6da5d349bb5d951090

Change-Id: I3ead4d9a1c5f4af2444ab9199b04774ab18e100c

dahlstrom-g

This file isn't in the source revision:
https://github.com/youtube/cobalt/blob/fd2b36a1/build/config/fuchsia/test/web_instance_host_capabilities.test-cmx
https://chromium.googlesource.com/chromium/src/+/114.0.5735.331/build/config/fuchsia/test

dahlstrom-g · 2024-01-12T22:14:10Z

build/BUILD.gn

 buildflag_header("chromecast_buildflags") {
  header = "chromecast_buildflags.h"

-  flags = [ "IS_CHROMECAST=$is_chromecast" ]
+  flags = [
+    "IS_CHROMECAST=$is_chromecast",


I don't see this in the source revision—
https://chromium.googlesource.com/chromium/src/+/114.0.5735.331/build/BUILD.gn#42
— but I see it's used in media which is of course at a different revision.

If would be much better to update Chromium versions synchronously
rather than having subtrees at various versions.
I hope we'll try to pivot in that direction before too long,
toward decreasing rather than continuing to increase dispersion.

dahlstrom-g · 2024-01-12T22:25:40Z

build/config/apple/sdk_info.py

+                      help='Value of gn $root_build_dir')
+  parser.add_argument('platform',
+                      choices=['iphoneos', 'iphonesimulator', 'macosx',
+                               'appletvos'])


I don't see this in the source revision:
https://chromium.googlesource.com/chromium/src/+/114.0.5735.331/build/config/apple/sdk_info.py#137
I also can't tell if it's used anywhere. Is it?

If we've added this for a reason
it would be good to have a comment explaining it.

dahlstrom-g · 2024-01-12T22:41:27Z

build/android/docs/coverage.md

Lines 32–35 aren't in the source revision:
https://chromium.googlesource.com/chromium/src/+show/114.0.5735.331/build/android/docs/coverage.md#32

dahlstrom-g · 2024-01-12T22:44:29Z

build/android/pylib/local/device/local_device_test_run.py

Lines 102–108 aren't in the source revision:
https://chromium.googlesource.com/chromium/src/+show/114.0.5735.331/build/android/pylib/local/device/local_device_test_run.py#102

dahlstrom-g · 2024-01-12T22:55:18Z

build/config/arm.gni

+        # or "softfp". An empty string means to use the default one for the
+        # arm_version.
+        arm_float_abi = ""
+      }


I've learned indenting upstream code tends to cause needless conflicts.

dahlstrom-g · 2024-01-13T00:10:44Z

build/toolchain/apple/toolchain.gni

+    } else {
+      toolchain_is_component_build = is_component_build
+    }
+


Lines 160–173 aren't in the source revision:
https://chromium.googlesource.com/chromium/src/+/114.0.5735.331/build/toolchain/apple/toolchain.gni#160

dahlstrom-g · 2024-01-13T00:12:47Z

build/toolchain/gcc_toolchain.gni

      } else {
-      command = "$asm -MMD -MF $depfile ${rebuild_string}{{defines}} {{include_dirs}} {{asmflags}}${extra_asmflags} -c {{source}} -o {{output}}"
+        command = "$asm $md -MF $depfile ${rebuild_string}{{defines}} {{include_dirs}} {{asmflags}}${extra_asmflags} -c {{source}} -o {{output}}"


ditto about indentation

dahlstrom-g · 2024-01-13T00:15:24Z

build/toolchain/ios/compile_xcassets.py

+  relative_path = relative_paths.get(absolute_path, absolute_path)
+  if absolute_path == relative_path:
+    return line
+  return relative_path + line[len(absolute_path):]


Lines 40–48 appear to duplicate lines 49–57.

dahlstrom-g · 2024-01-13T00:39:08Z

build/android/pylib/gtest/gtest_test_instance_test.py

+    self.assertEqual(1, len(actual))
+    self.assertEqual('mojom_tests.parse.ast_unittest.ASTTest.testNodeBase',
+                     actual[0].GetName())
+    self.assertEqual(base_test_result.ResultType.SKIP, actual[0].GetType())


Lines 283–313 appear to duplicate lines 314–344.

dahlstrom-g · 2024-01-13T00:41:56Z

build/android/pylib/results/json_results_test.py

+    self.assertTrue('PASS' not in results_dict['num_failures_by_type']
+                    or results_dict['num_failures_by_type']['PASS'] == 0)
+    self.assertIn('SKIP', results_dict['num_failures_by_type'])
+    self.assertEqual(1, results_dict['num_failures_by_type']['SKIP'])


Lines 244–271 appear to duplicate lines 272–299.

aee-google force-pushed the 114-update-build branch 12 times, most recently from 6394d51 to cd688cf Compare December 19, 2023 02:08

aee-google force-pushed the 114-update-build branch 7 times, most recently from f31a0e5 to 27cc798 Compare December 28, 2023 23:22

aee-google marked this pull request as ready for review December 28, 2023 23:22

aee-google requested a review from andrewsavage1 as a code owner December 28, 2023 23:22

andrewsavage1 requested changes Jan 2, 2024

View reviewed changes

aee-google force-pushed the 114-update-build branch from 27cc798 to 3c6b907 Compare January 2, 2024 21:23

aee-google added the on_device label Jan 2, 2024

andrewsavage1 reviewed Jan 8, 2024

View reviewed changes

build_overrides/util/is_python2.py Outdated Show resolved Hide resolved

andrewsavage1 approved these changes Jan 8, 2024

View reviewed changes

andrewsavage1 mentioned this pull request Jan 8, 2024

Starboardize base #2182

Closed

aee-google force-pushed the 114-update-build branch from 3c6b907 to 9cfbf1a Compare January 10, 2024 18:36

aee-google force-pushed the 114-update-build branch from 9cfbf1a to e4cc7ad Compare January 10, 2024 19:51

Updating //build to m114.0.5735.331.

423a1d3

Change-Id: Id47a9e956f64ee29344e5d6da5d349bb5d951090

aee-google force-pushed the 114-update-build branch from e4cc7ad to 8536dfd Compare January 10, 2024 20:38

Updating //build for cobalt.

ccd55f0

Change-Id: I3ead4d9a1c5f4af2444ab9199b04774ab18e100c

aee-google force-pushed the 114-update-build branch from 8536dfd to ccd55f0 Compare January 11, 2024 17:46

aee-google merged commit fd2b36a into youtube:main Jan 11, 2024
371 of 376 checks passed

aee-google deleted the 114-update-build branch January 11, 2024 20:17

aee-google restored the 114-update-build branch January 12, 2024 20:14

aee-google deleted the 114-update-build branch January 12, 2024 20:14

dahlstrom-g reviewed Jan 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update //build to m114.0.5735.331. #2100

Update //build to m114.0.5735.331. #2100

aee-google commented Dec 14, 2023

codecov bot commented Dec 29, 2023 •

edited

Loading

andrewsavage1 commented Jan 2, 2024

andrewsavage1 left a comment

dahlstrom-g left a comment

dahlstrom-g Jan 12, 2024

dahlstrom-g Jan 12, 2024

dahlstrom-g Jan 12, 2024

dahlstrom-g Jan 12, 2024

dahlstrom-g Jan 12, 2024

dahlstrom-g Jan 13, 2024

dahlstrom-g Jan 13, 2024

dahlstrom-g Jan 13, 2024

dahlstrom-g Jan 13, 2024

dahlstrom-g Jan 13, 2024

Update //build to m114.0.5735.331. #2100

Update //build to m114.0.5735.331. #2100

Conversation

aee-google commented Dec 14, 2023

codecov bot commented Dec 29, 2023 • edited Loading

Codecov Report

andrewsavage1 commented Jan 2, 2024

andrewsavage1 left a comment

Choose a reason for hiding this comment

dahlstrom-g left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 29, 2023 •

edited

Loading