Deprecate SbMemoryMap APIs. #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y4vor
force-pushed
the
mmap
branch
5 times, most recently
from
24f91cb
to
c049943
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
==========================================
+ Coverage 58.55% 58.63% +0.08%
==========================================
Files 1914 1901 -13
Lines 94432 94012 -420
==========================================
- Hits 55298 55128 -170
+ Misses 39134 38884 -250 ☔ View full report in Codecov by Sentry. |
y4vor
force-pushed
the
mmap
branch
4 times, most recently
from
cd5e042
to
9fe3ed8
Compare
gbournou
reviewed
Dec 15, 2023
gbournou
suggested changes
Dec 15, 2023
y4vor
force-pushed
the
mmap
branch
3 times, most recently
from
2b5fe3d
to
3ad229a
Compare
That should be gone as I think it was coming from Max's change. |
gbournou
approved these changes
Dec 18, 2023
- Deprecated SbMemoryMap, SbMemoryUnmap, SbMemoryProtect and SbMemoryFlush. b/302332972 Change-Id: I198963e11db32c14ecc35096691da00d6d690ddd
yjzhang111
approved these changes
Dec 19, 2023
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Dec 28, 2023
This reverts commit 139da0d. Broke builds on Raspi-2 b/302332972
kaidokert
added a commit
that referenced
this pull request
Dec 28, 2023
y4vor
added a commit
to y4vor/cobalt
that referenced
this pull request
Jan 12, 2024
This reverts commit a684fb0. Change-Id: If38bea327255c4e5bce013e9e7c389ff57c675d5
y4vor
added a commit
to y4vor/cobalt
that referenced
this pull request
Jan 12, 2024
This reverts commit a684fb0. b/302332972 Change-Id: If38bea327255c4e5bce013e9e7c389ff57c675d5
y4vor
added a commit
to y4vor/cobalt
that referenced
this pull request
Jan 13, 2024
This reverts commit a684fb0. Added mmap wrapping to manage the off_t type differences on platforms like raspi-2. b/302332972 Change-Id: If38bea327255c4e5bce013e9e7c389ff57c675d5
y4vor
added a commit
to y4vor/cobalt
that referenced
this pull request
Jan 13, 2024
This reverts commit a684fb0. Added mmap wrapping to manage the off_t type differences on platforms like raspi-2. b/302332972 Change-Id: If38bea327255c4e5bce013e9e7c389ff57c675d5
y4vor
added a commit
to y4vor/cobalt
that referenced
this pull request
Jan 16, 2024
This reverts commit a684fb0. Added mmap wrapping to manage the off_t type differences on platforms like raspi-2. b/302332972 Change-Id: If38bea327255c4e5bce013e9e7c389ff57c675d5
dahlstrom-g
pushed a commit
that referenced
this pull request
Oct 30, 2024
Uploaded by https://ci.chromium.org/b/8738505171997425025 Change-Id: I97cb38c7db8029bc94e733819844b638921f1940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817034 Bot-Commit: ChromeOS bot <[email protected]> Commit-Queue: Yuta Hijikata <[email protected]> Cr-Commit-Position: refs/branch-heads/6099@{#2064} Cr-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/302332972
Change-Id: I198963e11db32c14ecc35096691da00d6d690ddd