Rename global variable in eztime #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1fca5d8fb34f7f670e3c5e4c78860755d6315cee
y4vor
approved these changes
Dec 4, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
==========================================
- Coverage 58.68% 58.66% -0.02%
==========================================
Files 1907 1907
Lines 94073 94073
==========================================
- Hits 55203 55191 -12
- Misses 38870 38882 +12 ☔ View full report in Codecov by Sentry. |
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
Avoid a confusing symbol name clash between `g_initialization_once` in icu_init.cc and eztime.cc by renaming the eztime symbol to `g_eztime_initialization_once` Note that both symbols are in anonymous namespaces so - they are not the same. See b/246412559#comment66 , #60 for more details. b/246412559 (cherry picked from commit 401d1c7)
niranjanyardi
added a commit
that referenced
this pull request
Dec 6, 2023
Refer to the original PR: #2040 Avoid a confusing symbol name clash between `g_initialization_once` in icu_init.cc and eztime.cc by renaming the eztime symbol to `g_eztime_initialization_once` Note that both symbols are in anonymous namespaces so - they are not the same. See b/246412559#comment66 , #60 for more details. b/246412559 Co-authored-by: Niranjan Yardi <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Avoid a confusing symbol name clash between `g_initialization_once` in icu_init.cc and eztime.cc by renaming the eztime symbol to `g_eztime_initialization_once` Note that both symbols are in anonymous namespaces so - they are not the same. See b/246412559#comment66 , youtube#60 for more details. b/246412559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a confusing symbol name clash between
g_initialization_oncein icu_init.cc and eztime.cc by renaming the eztime symbol tog_eztime_initialization_onceNote that both symbols are in anonymous namespaces so - they are not the same.
See b/246412559#comment66 , #60 for more details.
b/246412559