Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick V8 commit eec25f21 #2034

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Cherry-pick V8 commit eec25f21 #2034

merged 1 commit into from
Dec 1, 2023

Conversation

dahlstrom-g
Copy link
Contributor

b/314179829

aelzeiny
aelzeiny approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@aelzeiny aelzeiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dana for picking this up so quickly. I'm testing locally and I think this represents the full extent of what we need to get JS Stack Traces working.

@dahlstrom-g
[Callback] Execute DiscardedSamplesDelegate Callback when
dc5c006 
samples being discarded

 - Passed in as CpuProfilingOptions parameter, client is responsible for
determining if function is still safe to execute. Includes unit tests

 - Client (blink) side CR: https://chromium-review.googlesource.com/c/chromium/src/+/2649617,
 - Client (blink) side CR requires this to be pushed prior to it being pushed

(cherry picked from commit eec25f2199e726d7915b15e29ad7718ae5e09711)

Change-Id: I3ef4640186115d4e14c1b73f902c889c776e310f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652206
Commit-Queue: Nicolas Dubus <[email protected]>
Reviewed-by: Ulan Degenbaev <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#72794}
@youtube youtube deleted a comment from codecov bot Dec 1, 2023
@youtube youtube deleted a comment from codecov bot Dec 1, 2023
@dahlstrom-g dahlstrom-g merged commit 0cd1dff into youtube:main Dec 1, 2023
321 of 328 checks passed
@dahlstrom-g dahlstrom-g deleted the I3ef46401 branch December 1, 2023 20:12
@aelzeiny aelzeiny added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 2, 2024
@aelzeiny aelzeiny mentioned this pull request Jan 2, 2024
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jan 2, 2024
@dahlstrom-g @anonymous1-me
Cherry-pick V8 commit eec25f21
dba7ec5 
Issue: 314179829
Reviewed-on: #2034
(cherry picked from commit 0cd1dff)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Jan 2, 2024
Merged
kaidokert pushed a commit that referenced this pull request Jan 2, 2024
@dahlstrom-g @kaidokert
Cherry-pick V8 commit eec25f21
15c960c 
Issue: 314179829
Reviewed-on: #2034
(cherry picked from commit 0cd1dff)
kaidokert pushed a commit that referenced this pull request Jan 2, 2024
@cobalt-github-releaser-bot @dahlstrom-g
Cherry pick PR #2034: Cherry-pick V8 commit eec25f21 (#2149)
8b37a66 
Refer to the original PR: #2034

b/314179829

Co-authored-by: Dana Dahlstrom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelzeiny aelzeiny aelzeiny approved these changes

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlstrom-g @aelzeiny