Stop using exhaustive switch statements #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2029 +/- ##
==========================================
+ Coverage 58.12% 58.68% +0.56%
==========================================
Files 1907 1907
Lines 95200 94073 -1127
==========================================
- Hits 55336 55208 -128
+ Misses 39864 38865 -999 ☔ View full report in Codecov by Sentry. |
jellefoks
requested review from
dahlstrom-g,
hlwarriner,
aee-google and
sherryzy
jellefoks
force-pushed
the
default_enum_case
branch
from
2a06f5a
to
6a372bc
Compare
sherryzy
approved these changes
Dec 4, 2023
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
We no longer have compilers (or compiler settings) that enforce exhaustive switch statements for enums. That means we can now use 'default' cases where that makes more sense. b/314002146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer have compilers (or compiler settings) that enforce exhaustive switch statements for enums. That means we can now use 'default' cases where that makes more sense.
b/314002146