Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Git trailer Build-Id #2013

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Accept Git trailer Build-Id #2013

merged 1 commit into from
Nov 29, 2023

Conversation

dahlstrom-g
Copy link
Contributor

… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

b/296119824

@dahlstrom-g
Accept Git trailer Build-Id
cdc59d8 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

b/296119824
@andrewsavage1
Copy link
Contributor

So will this be cherry picked to all LTS branches?

@dahlstrom-g
Copy link
Contributor Author

So will this be cherry picked to all LTS branches?

That's what I understand from the conversation yesterday.

@dahlstrom-g dahlstrom-g reopened this Nov 28, 2023
@dahlstrom-g dahlstrom-g merged commit 0e24f1d into youtube:main Nov 29, 2023
645 of 657 checks passed
@dahlstrom-g dahlstrom-g added cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-22.lts.1+ Cherry Pick to the 22.lts.1+ branch cp-21.lts.1+ Cherry Pick to the 21.lts.1+ branch cp-20.lts.1+ Cherry Pick to the 20.lts.1+ branch cp-19.lts.1+ cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch labels Nov 29, 2023
@dahlstrom-g dahlstrom-g deleted the b296119824 branch November 29, 2023 02:00
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Nov 29, 2023
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
9cbea0b 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
This was referenced Nov 29, 2023
Merged
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
97257cf 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
b2c5048 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Nov 29, 2023
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
de4831f 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
61dd90e 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
This was referenced Nov 29, 2023
Merged
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
56fd9f1 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
f119d13 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Nov 29, 2023
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g @anonymous1-me
Accept Git trailer Build-Id
ddb1bbd 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
(cherry picked from commit 0e24f1d)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Nov 29, 2023
Merged
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
4a990c8 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
681f598 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
a0226db 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
11dc52a 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
dbe141a 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
8483f63 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
cc806e9 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g added a commit that referenced this pull request Nov 29, 2023
@dahlstrom-g
Accept Git trailer Build-Id
186d68d 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: #2013
dahlstrom-g pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot
Accept Git trailer Build-Id
cca8c68 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

(cherry picked from commit 0e24f1d)

Issue: 296119824
Reviewed-on: #2013
Reviewed-on: #2023
dahlstrom-g pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot
Accept Git trailer Build-Id
fb24a20 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

(cherry picked from commit 0e24f1d)

Issue: 296119824
Reviewed-on: #2013
Reviewed-on: #2018
dahlstrom-g pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot
Accept Git trailer Build-Id
07f2217 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

(cherry picked from commit 0e24f1d)

Issue: 296119824
Reviewed-on: #2013
Reviewed-on: #2024
dahlstrom-g pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot
Accept Git trailer Build-Id
d4d90b6 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

(cherry picked from commit 0e24f1d)

Issue: 296119824
Reviewed-on: #2013
Reviewed-on: #2022
dahlstrom-g pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot
Accept Git trailer Build-Id
e8b43e0 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

(cherry picked from commit 0e24f1d)

Issue: 296119824
Reviewed-on: #2013
Reviewed-on: #2025
dahlstrom-g pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot
Accept Git trailer Build-Id
9cdccc3 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

(cherry picked from commit 0e24f1d)

Issue: 296119824
Reviewed-on: #2013
Reviewed-on: #2021
andrewsavage1 pushed a commit that referenced this pull request Nov 29, 2023
@cobalt-github-releaser-bot @dahlstrom-g
Cherry pick PR #2013: Accept Git trailer Build-Id (#2019)
deecd78 
Refer to the original PR: #2013

… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

b/296119824

Co-authored-by: Dana Dahlstrom <[email protected]>
kaidokert pushed a commit that referenced this pull request Dec 1, 2023
@cobalt-github-releaser-bot @dahlstrom-g
Cherry pick PR #2013: Accept Git trailer Build-Id (#2020)
b02c49d 
Refer to the original PR: #2013

… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

b/296119824

Co-authored-by: Dana Dahlstrom <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
@dahlstrom-g @Rongo-JL
Accept Git trailer Build-Id
b1c273d 
… in place of Piper tag BUILD_NUMBER, to avoid corrupting Git trailers.

Issue: 296119824
Reviewed-on: youtube#2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

Assignees
No one assigned
Labels
cp-20.lts.1+ Cherry Pick to the 20.lts.1+ branch cp-21.lts.1+ Cherry Pick to the 21.lts.1+ branch cp-22.lts.1+ Cherry Pick to the 22.lts.1+ branch cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahlstrom-g @andrewsavage1