Deprecate SbTime APIs (partial) #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbournou
force-pushed
the
sbtime
branch
6 times, most recently
from
9dfa2d7
to
eaf27fe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 58.54% 58.53% -0.01%
==========================================
Files 1911 1914 +3
Lines 94379 94432 +53
==========================================
+ Hits 55252 55276 +24
- Misses 39127 39156 +29 ☔ View full report in Codecov by Sentry. |
dahlstrom-g
force-pushed
the
sbtime
branch
4 times, most recently
from
9dfa2d7
to
eaf27fe
Compare
gbournou
force-pushed
the
sbtime
branch
19 times, most recently
from
896589c
to
0d55b18
Compare
gbournou
force-pushed
the
sbtime
branch
2 times, most recently
from
e6308fb
to
185ec1c
Compare
y4vor
reviewed
Dec 12, 2023
gbournou
force-pushed
the
sbtime
branch
4 times, most recently
from
ba9c5e2
to
539ac20
Compare
gbournou
force-pushed
the
sbtime
branch
5 times, most recently
from
f619af1
to
fed0f28
Compare
|
The 45 failing tests all seem unrelated (see http://b/316393043). |
y4vor
reviewed
Dec 15, 2023
y4vor
approved these changes
Dec 15, 2023
andrewsavage1
approved these changes
Dec 15, 2023
- Add emulation of POSIX APIs for Windows platforms - Provide common helper functions to simplify getting usec timestamps - Replace usages of SbTimeGetNow and SbTimeGetMonotonicNow in `cobalt` b/302733082 Test-On-Device: true
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
- Add emulation of POSIX APIs for Windows platforms - Provide common helper functions to simplify getting usec timestamps - Replace usages of SbTimeGetNow and SbTimeGetMonotonicNow in `cobalt` b/302733082 Test-On-Device: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cobaltb/302733082
Test-On-Device: true