Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure that MP3, FLAC, and PCM are not supported for MediaSource." #2005

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

jasonzhangxx
Copy link
Contributor

@jasonzhangxx jasonzhangxx commented Nov 21, 2023

Reverts #1359

b/297060983

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Nov 21, 2023

Datadog Report

Branch report: revert-1359-isTypeSupported_fix
Commit report: db834e9

cobalt: 0 Failed, 0 New Flaky, 29572 Passed, 1 Skipped, 10m 55.36s Wall Time

@jasonzhangxx jasonzhangxx enabled auto-merge (squash) November 21, 2023 21:35
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fbfbaa7) 57.68% compared to head (db834e9) 57.70%.

Files Patch % Lines
cobalt/media/media_module.cc 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
+ Coverage   57.68%   57.70%   +0.01%     
==========================================
  Files        1907     1907              
  Lines       95190    95185       -5     
==========================================
+ Hits        54912    54923      +11     
+ Misses      40278    40262      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonzhangxx jasonzhangxx enabled auto-merge (squash) November 22, 2023 18:10
@jasonzhangxx jasonzhangxx merged commit 85e1b18 into main Nov 22, 2023
343 of 346 checks passed
@jasonzhangxx jasonzhangxx deleted the revert-1359-isTypeSupported_fix branch November 22, 2023 18:11
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants