Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick PR #1969: Add GetPersistentSetting() to h5vcc_settings. #1994

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Cherry pick PR #1969: Add GetPersistentSetting() to h5vcc_settings. #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions cobalt/h5vcc/h5vcc_settings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,5 +104,22 @@ bool H5vccSettings::Set(const std::string& name, SetValueType value) const {
return false;
}

void H5vccSettings::SetPersistentSettingAsInt(const std::string& key,
int value) const {
if (persistent_settings_) {
persistent_settings_->SetPersistentSetting(
key, std::make_unique<base::Value>(value));
}
}

int H5vccSettings::GetPersistentSettingAsInt(const std::string& key,
int default_setting) const {
if (persistent_settings_) {
return persistent_settings_->GetPersistentSettingAsInt(key,
default_setting);
}
return default_setting;
}

} // namespace h5vcc
} // namespace cobalt
5 changes: 5 additions & 0 deletions cobalt/h5vcc/h5vcc_settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ class H5vccSettings : public script::Wrappable {
// invalid or not set to the expected value.
bool Set(const std::string& name, SetValueType value) const;

void SetPersistentSettingAsInt(const std::string& key, int value) const;

int GetPersistentSettingAsInt(const std::string& key,
int default_setting) const;

DEFINE_WRAPPABLE_TYPE(H5vccSettings);

private:
Expand Down
2 changes: 2 additions & 0 deletions cobalt/h5vcc/h5vcc_settings.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@

interface H5vccSettings {
boolean set(DOMString name, (long or DOMString) value);
void setPersistentSettingAsInt(DOMString name, long value);
long getPersistentSettingAsInt(DOMString name, long default_setting);
};