-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SbStringCompareNoCase #1981
Conversation
cobalt/renderer/rasterizer/skia/skia/src/ports/SkFontMgr_cobalt.cc
Outdated
Show resolved
Hide resolved
cobalt/renderer/rasterizer/skia/skia/src/ports/SkFontMgr_cobalt.cc
Outdated
Show resolved
Hide resolved
cobalt/renderer/rasterizer/skia/skia/src/ports/SkFontStyleSet_cobalt.cc
Outdated
Show resolved
Hide resolved
cobalt/renderer/rasterizer/skia/skia/src/ports/SkFontStyleSet_cobalt.cc
Outdated
Show resolved
Hide resolved
5318a32
to
619882e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
=======================================
Coverage 57.69% 57.70%
=======================================
Files 1909 1907 -2
Lines 95199 95190 -9
=======================================
Hits 54927 54927
+ Misses 40272 40263 -9 ☔ View full report in Codecov by Sentry. |
for the stub failures, please add the symbol to the list of posix symbols:
And for win32 you need to define something like in starboard/shared/win32/posix_emu/include/stdlib.h |
8e56b66
to
75bf163
Compare
Change-Id: I4576891a0f6b2036f879c97d6026d666ad273030
b/305768669