Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SbStringCompareNoCase #1981

Merged
merged 8 commits into from
Nov 17, 2023

Conversation

madhurajayaraman
Copy link
Contributor

b/305768669

cobalt/debug/console/command_manager.cc Outdated Show resolved Hide resolved
cobalt/dom/on_screen_keyboard.cc Outdated Show resolved Hide resolved
cobalt/loader/cors_preflight.cc Outdated Show resolved Hide resolved
cobalt/loader/cors_preflight.cc Outdated Show resolved Hide resolved
cobalt/loader/cors_preflight.cc Outdated Show resolved Hide resolved
starboard/client_porting/poem/strings_poem.h Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (9fd3a9c) 57.69% compared to head (ef93e17) 57.70%.

Files Patch % Lines
cobalt/loader/cors_preflight.cc 0.00% 6 Missing ⚠️
...rizer/skia/skia/src/ports/SkFontStyleSet_cobalt.cc 20.00% 4 Missing ⚠️
cobalt/debug/console/command_manager.cc 0.00% 3 Missing ⚠️
cobalt/dom/on_screen_keyboard.cc 0.00% 1 Missing ⚠️
cobalt/loader/cors_preflight_cache.cc 0.00% 1 Missing ⚠️
cobalt/loader/cors_preflight_cache.h 0.00% 1 Missing ⚠️
...rasterizer/skia/skia/src/ports/SkFontMgr_cobalt.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1981   +/-   ##
=======================================
  Coverage   57.69%   57.70%           
=======================================
  Files        1909     1907    -2     
  Lines       95199    95190    -9     
=======================================
  Hits        54927    54927           
+ Misses      40272    40263    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y4vor
Copy link
Contributor

y4vor commented Nov 16, 2023

for the stub failures, please add the symbol to the list of posix symbols:

_ALLOWED_SB16_POSIX_SYMBOLS = [

And for win32 you need to define something like
#define stricmp _stricmp

in starboard/shared/win32/posix_emu/include/stdlib.h

@madhurajayaraman madhurajayaraman marked this pull request as ready for review November 17, 2023 15:17
starboard/nplb/string_duplicate_test.cc Outdated Show resolved Hide resolved
Change-Id: I4576891a0f6b2036f879c97d6026d666ad273030
@madhurajayaraman madhurajayaraman merged commit 5c77d54 into youtube:main Nov 17, 2023
332 of 334 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants