Add GetPersistentSetting() to h5vcc_settings. #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbournou
reviewed
Nov 13, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
=======================================
Coverage 57.68% 57.68%
=======================================
Files 1909 1909
Lines 95134 95143 +9
=======================================
+ Hits 54878 54887 +9
Misses 40256 40256 ☔ View full report in Codecov by Sentry. |
gbournou
approved these changes
Nov 14, 2023
joeltine
requested changes
Nov 14, 2023
The getters and setters allows JS testing and validation of Persistent Settings. b/305057554
joeltine
approved these changes
Nov 15, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
Add a persistent settings getter to validate set persistent h5vcc settings. The getter is a string getter that maps to the various types that allows for empty string returns when the getter fails. b/305057554 (cherry picked from commit 2e8c30c)
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Add a persistent settings getter to validate set persistent h5vcc settings. The getter is a string getter that maps to the various types that allows for empty string returns when the getter fails. b/305057554
kaidokert
pushed a commit
that referenced
this pull request
Jan 2, 2024
…1994) Refer to the original PR: #1969 Add a persistent settings getter to validate set persistent h5vcc settings. The getter is a string getter that maps to the various types that allows for empty string returns when the getter fails. b/305057554 Co-authored-by: Brian Ting <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a persistent settings getter to validate set persistent h5vcc settings. The getter is a string getter that maps to the various types that allows for empty string returns when the getter fails.
b/305057554