Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SbStringScan function #1958

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Conversation

yjzhang111
Copy link
Contributor

b/307808954

Change-Id: I2d30ba1c332efbb45ff66ab170772bf0201fb3d3

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a6d3ba) 58.64% compared to head (0a7eca0) 58.66%.
Report is 1 commits behind head on main.

Files Patch % Lines
cobalt/dom/on_screen_keyboard.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
+ Coverage   58.64%   58.66%   +0.02%     
==========================================
  Files        1906     1906              
  Lines       93795    94063     +268     
==========================================
+ Hits        55008    55184     +176     
- Misses      38787    38879      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yjzhang111 yjzhang111 changed the base branch from main to starboard November 16, 2023 02:17
@yjzhang111 yjzhang111 changed the base branch from starboard to main November 16, 2023 02:17
@yjzhang111 yjzhang111 force-pushed the starboard branch 7 times, most recently from 9e7bd1c to 5db19b2 Compare November 22, 2023 20:23
Copy link
Contributor

@y4vor y4vor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update starboard/CHANGELOG.md too.

starboard/client_porting/poem/stdio_poem.h Outdated Show resolved Hide resolved
starboard/string.h Outdated Show resolved Hide resolved
third_party/skia/src/gpu/gl/GrGLUtil.cpp Show resolved Hide resolved
@yjzhang111 yjzhang111 marked this pull request as ready for review December 7, 2023 19:44
b/307808954

Change-Id: I2d30ba1c332efbb45ff66ab170772bf0201fb3d3
b/307808954

Change-Id: I0387481032a64b384a17e413f2323e52191822c8
Change-Id: Ib6c3a9c2115508daa5e5ea544d2d09b7520161d8
Change-Id: I168d3d957e4a07c4e6dbf98270d7792d41b20859
Change-Id: I65c4bbf51d8833e4f636055f1393e315ae7c3c74
Change-Id: I8d2ed6adbd423b37ca41aa99b3b8468f81f61e7e
Change-Id: Ib82e5da567741d7494458d66c9c6a5a5cd997d7b
Change-Id: I8a8d2832dbc03cb7a4c073bf5ddc4097227240dc
@yjzhang111 yjzhang111 merged commit 0ea59cc into youtube:main Dec 12, 2023
333 of 334 checks passed
@yjzhang111 yjzhang111 deleted the starboard branch December 12, 2023 23:29
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
b/307808954

Change-Id: I2d30ba1c332efbb45ff66ab170772bf0201fb3d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants