Refine Stub Audio Decoder threading #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift consumed and output callbacks to the renderer thread instead of the decoder thread, as calls on the decoder thread caused DCHECK failures. b/309831511
osagie98
requested review from
xiaomings,
sideb0ard,
jasonzhangxx and
borongc
xiaomings
approved these changes
Nov 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #1941 +/- ##
==========================================
- Coverage 57.75% 57.74% -0.02%
==========================================
Files 1916 1916
Lines 95115 95116 +1
==========================================
- Hits 54936 54921 -15
- Misses 40179 40195 +16
|
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Shift consumed and output callbacks to the renderer thread instead of the decoder thread, as calls on the decoder thread caused DCHECK failures. b/309831511 (cherry picked from commit 31b1c90)
osagie98
added a commit
that referenced
this pull request
Nov 8, 2023
Refer to the original PR: #1941 Shift consumed and output callbacks to the renderer thread instead of the decoder thread, as calls on the decoder thread caused DCHECK failures. b/309831511 Co-authored-by: Austin Osagie <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Shift consumed and output callbacks to the renderer thread instead of the decoder thread, as calls on the decoder thread caused DCHECK failures. b/309831511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift consumed and output callbacks to the renderer thread instead of the decoder thread, as calls on the decoder thread caused DCHECK failures.
b/309831511