Convert hybrid nav to starboard extension

[iuriionishchenko]

Refactoring to move the AppleTV hybrid nav implementation from a Starboard API to a Starboard extension

b/299481829

[codecov]

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (980c2a5) 58.54% compared to head (4bbfa76) 58.55%.

Files	Patch %	Lines
cobalt/ui_navigation/interface.cc	22.58%	24 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
+ Coverage   58.54%   58.55%   +0.01%     
==========================================
  Files        1912     1911       -1     
  Lines       94578    94585       +7     
==========================================
+ Hits        55370    55386      +16     
+ Misses      39208    39199       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gbournou]

This is a good start - thanks for working on this

[gbournou]

The code here looks good (just a couple nits).

Do you already have the corresponding Gerrit change for the internal files (e.g. //internal/starboard/shared/uikit/ui_nav_get_interface.mm)? We'll need to submit them roughly at the same time so things don't break. Also, if you do have the internal Gerrit change ready, we should make a temporary change that include both that and this Github change so we can run the Apple TV builds/tests on it and verify nothing broke.

[iuriionishchenko]

CL for internal files was created - 272340

[gbournou]

CL for internal files was created - 272340

Great, as mentioned in my other comment, let's make a temporary internal CL that includes the changes in this GH PR as well as the changes in 272340. We can then use that temporary internal CL to run our tvOS tests to ensure everything works together.

[iuriionishchenko]

A temporary CL 272580 was added. There are changes of internal files and GH files.

[gbournou]

A temporary CL 272580 was added. There are changes of internal files and GH files.

Great - it looks like tvOS builds worked successfully there.