Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starboard IFA extension. #1929

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add Starboard IFA extension. #1929

merged 1 commit into from
Nov 7, 2023

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented Nov 7, 2023

This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724

cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
cobalt/h5vcc/h5vcc_system.cc Outdated Show resolved Hide resolved
starboard/linux/shared/system_get_extensions.cc Outdated Show resolved Hide resolved
starboard/linux/shared/system_get_extensions.cc Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1929 (b3a7c12) into main (2277260) will decrease coverage by 0.02%.
Report is 8 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   57.77%   57.76%   -0.02%     
==========================================
  Files        1915     1916       +1     
  Lines       95118    95117       -1     
==========================================
- Hits        54959    54948      -11     
- Misses      40159    40169      +10     
Files Coverage Δ
starboard/extension/ifa.h 100.00% <100.00%> (ø)
starboard/linux/shared/system_get_extensions.cc 70.00% <ø> (ø)
cobalt/h5vcc/h5vcc_system.cc 1.96% <0.00%> (+0.07%) ⬆️

... and 5 files with indirect coverage changes

This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
@y4vor y4vor merged commit 4a1d1cc into youtube:main Nov 7, 2023
332 of 334 checks passed
@y4vor y4vor added cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch labels Nov 7, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 7, 2023
This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
(cherry picked from commit 4a1d1cc)
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 7, 2023
This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
(cherry picked from commit 4a1d1cc)
y4vor added a commit that referenced this pull request Nov 7, 2023
Refer to the original PR: #1929

This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724

Co-authored-by: y4vor <[email protected]>
y4vor added a commit that referenced this pull request Nov 7, 2023
This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
(cherry picked from commit 4a1d1cc)
y4vor added a commit that referenced this pull request Nov 7, 2023
This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
(cherry picked from commit 4a1d1cc)
y4vor added a commit that referenced this pull request Nov 7, 2023
Refer to the original PR: #1929

This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724

Co-authored-by: y4vor <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
borongc pushed a commit to borongc/cobalt that referenced this pull request Apr 9, 2024
This extension would allow IFA backporting to
Starboard version 12 or 13.

b/309547847

Change-Id: If3dc2a1eb13377ce33463d2d9bb0b14e33089724
@y4vor y4vor deleted the ifa_extension branch May 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants