Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change symbol visibility to hidden for modular builds #1920

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Nov 6, 2023

b/309646900

@niranjanyardi niranjanyardi changed the title Change symbol visibility to hidden Change symbol visibility to hidden for modular builds Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1920 (029d776) into main (2277260) will decrease coverage by 0.02%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

❗ Current head 029d776 differs from pull request most recent head e39469a. Consider uploading reports for the commit e39469a to get more accurate results

@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
- Coverage   57.77%   57.76%   -0.02%     
==========================================
  Files        1915     1915              
  Lines       95118    95118              
==========================================
- Hits        54959    54947      -12     
- Misses      40159    40171      +12     

see 5 files with indirect coverage changes

Change-Id: Ida7874b610359db13be294c7fcd55ab70ca4ace4
@niranjanyardi niranjanyardi merged commit f7aa084 into youtube:main Nov 7, 2023
334 of 340 checks passed
@niranjanyardi niranjanyardi added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Nov 9, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 9, 2023
niranjanyardi added a commit that referenced this pull request Nov 10, 2023
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
kaidokert pushed a commit that referenced this pull request Jan 2, 2024
kaidokert pushed a commit that referenced this pull request Jan 3, 2024
niranjanyardi added a commit that referenced this pull request Jan 25, 2024
niranjanyardi added a commit that referenced this pull request Feb 7, 2024
…builds (#1954)

Refer to the original PR: #1920

b/309646900

Co-authored-by: Niranjan Yardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch ignore-for-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants