Add flag to include integration test in app_launcher #1870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including these files adds tens of thousands of files that significantly increases extraction times on windows. By adding a flag we can control if to include these files in the archive. b/294130306
Datadog ReportBranch report: ✅ |
Codecov Report
@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 57.75% 57.77% +0.01%
==========================================
Files 1915 1915
Lines 95111 95111
==========================================
+ Hits 54931 54950 +19
+ Misses 40180 40161 -19 |
|
I believe app_launcher.zip was only used by device server platforms so this change should be safe to merge since we don't run these tests on any of them. |
briantting
approved these changes
Nov 1, 2023
|
This is superseeded by #1901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including these files adds tens of thousands of files that significantly increases extraction times on windows. By adding a flag we can control if to include these files in the archive.
b/294130306